1704579 - Skeleton UI pops up briefly when starting with an update pending

Status: NEW

(Toolkit :: Startup and Profile System, defect, P3)

Description

[Alex Thayer [:alexical] (she/her)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1693180#c2

Comment 1

[Alex Thayer [:alexical] (she/her)]

Hey Kirk, where is the code that does this? I.e., if you close and start Firefox manually after an update has been staged, it looks like we exit and apply the update and then restart. Is this correct? I'm looking for a cheap way of checking the state of the filesystem for the possibility of a pending update so we can not show the skeleton UI in that case. (This would be before loading xul.dll)

Comment 2

[Robin Steuber (she/her) [:bytesized]]

if you close and start Firefox manually after an update has been staged, it looks like we exit and apply the update and then restart. Is this correct?

Yes.

where is the code that does this?

The code that decides whether we need to process an update on startup lives here.

I'm looking for a cheap way of checking the state of the filesystem for the possibility of a pending update

The file that you would want would probably be <update dir>/updates/0/update.status. I'm not super keen on reading that file twice during startup though.