1693222 - Highlight on mac should return text selection background, not accent color

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

That matches other browsers and the intent of the spec.

Browser usage of Highlight / HighlightText should probably be changed to -moz-accent-color and -moz-accent-color-foreground. On Windows that effectively doesn't change anything.

Comment 1

[Markus Stange [:mstange]]

I've filed https://github.com/w3c/csswg-drafts/issues/6008 to get the spec clarified, and to discuss the addition of a new color name.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Ok, added it to the agenda, let's wait till that's resolved to proceed here.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

We have a resolution and edits!

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1693222 - Implement SelectedItem and SelectedItemText system colors. r=mstange

Since Highlight / HighlightText are now equivalent to the text selection
ones, remove those too.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28a0487d0291
Implement SelectedItem and SelectedItemText system colors. r=mstange

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30289 for changes under testing/web-platform/tests

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42569e93f788
Remove highlighttext from property_database.js as it can legitimately be currentColor in some platforms.

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for reftest failure on themed-widget.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/358ce9525a988b8fd9d175fae125ee5b53747794
Log link: https://treeherder.mozilla.org/logviewer?job_id=350268172&repo=autoland&lineNumber=7912

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Gah, getting backed out for unexpected passes is unfortunate. Thanks.

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/42569e93f788

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/095bdc8c1839
Implement SelectedItem and SelectedItemText system colors. r=mstange

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0e9983d1650
Fix two Higlight -> Highlight typos.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a964915b6a48
Fix selecteditem color on macOS.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/528d292dca73
Fix a mochitest failure that wasn't caught by try.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8422fd05dab
And fix a shameless copy-paste of the same test fixed on the previous commit.

Comment 17

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/095bdc8c1839
https://hg.mozilla.org/mozilla-central/rev/b0e9983d1650
https://hg.mozilla.org/mozilla-central/rev/a964915b6a48
https://hg.mozilla.org/mozilla-central/rev/528d292dca73
https://hg.mozilla.org/mozilla-central/rev/e8422fd05dab

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 19

[Sebastian Zartner [:sebo]]

The two new color values SelectedItem and SelectedItemText should be documented at https://developer.mozilla.org/en-US/docs/Web/CSS/color_value. For reference, they meanwhile got added to the CSS Color 4 specification.

Sebastian