Closed Bug 1693222 Opened 10 months ago Closed 3 months ago

Highlight on mac should return text selection background, not accent color

Categories

(Core :: Widget: Cocoa, defect, P2)

defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

()

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

That matches other browsers and the intent of the spec.

Browser usage of Highlight / HighlightText should probably be changed to -moz-accent-color and -moz-accent-color-foreground. On Windows that effectively doesn't change anything.

Flags: needinfo?(emilio)

I've filed https://github.com/w3c/csswg-drafts/issues/6008 to get the spec clarified, and to discuss the addition of a new color name.

Ok, added it to the agenda, let's wait till that's resolved to proceed here.

Flags: needinfo?(emilio)
Severity: -- → S3
Priority: -- → P2

We have a resolution and edits!

Flags: needinfo?(emilio)

Since Highlight / HighlightText are now equivalent to the text selection
ones, remove those too.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28a0487d0291
Implement SelectedItem and SelectedItemText system colors. r=mstange
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30289 for changes under testing/web-platform/tests
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/42569e93f788
Remove highlighttext from property_database.js as it can legitimately be currentColor in some platforms.
Upstream PR was closed without merging

Gah, getting backed out for unexpected passes is unfortunate. Thanks.

Flags: needinfo?(emilio)
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/095bdc8c1839
Implement SelectedItem and SelectedItemText system colors. r=mstange
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/b0e9983d1650
Fix two Higlight -> Highlight typos.
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/a964915b6a48
Fix selecteditem color on macOS.
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/528d292dca73
Fix a mochitest failure that wasn't caught by try.
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/e8422fd05dab
And fix a shameless copy-paste of the same test fixed on the previous commit.
Upstream PR merged by moz-wptsync-bot
Regressions: 1729645
Depends on: 1730138
Regressions: 1730752

The two new color values SelectedItem and SelectedItemText should be documented at https://developer.mozilla.org/en-US/docs/Web/CSS/color_value. For reference, they meanwhile got added to the CSS Color 4 specification.

Sebastian

Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.