1729645 - Selected focused treechildrens have a faint blue background

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Richard Marti (:Paenglab)]

On Mac the selected focused treechildren have a faint blue background instead of the dark blue the system uses in Finder.

This is a regression of bug 1693222 and at least https://searchfox.org/mozilla-central/source/toolkit/themes/shared/tree.inc.css#47 needs to be adapted.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Yep, wanna send a patch? Happy to review. I can get to it later otherwise.

Comment 2

[Richard Marti (:Paenglab)]

The earliest I could do it it would be this evening.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1729645 - Fix some missing Highlight -> SelectedItem replacements. r=mstange

All these are about item selection / not text selection, so they
shouldn't use Highlight.

Not sure what search I did on the regressing bug to miss these.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1693222

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/193d0be6ed5b
Fix some missing Highlight -> SelectedItem replacements. r=mstange

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/193d0be6ed5b

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9240028 [details]
Bug 1729645 - Fix some missing Highlight -> SelectedItem replacements. r=mstange

Beta/Release Uplift Approval Request

• User impact if declined: Wrong highlight colors in some parts of the UI.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix.
• String changes made/needed: none

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/8ffc502eedc3