Closed Bug 1729645 Opened 3 months ago Closed 3 months ago

Selected focused treechildrens have a faint blue background

Categories

(Core :: Widget, defect)

Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox92 --- unaffected
firefox93 --- fixed
firefox94 --- fixed

People

(Reporter: Paenglab, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

On Mac the selected focused treechildren have a faint blue background instead of the dark blue the system uses in Finder.

This is a regression of bug 1693222 and at least https://searchfox.org/mozilla-central/source/toolkit/themes/shared/tree.inc.css#47 needs to be adapted.

Yep, wanna send a patch? Happy to review. I can get to it later otherwise.

Flags: needinfo?(richard.marti)

The earliest I could do it it would be this evening.

Flags: needinfo?(richard.marti)

All these are about item selection / not text selection, so they
shouldn't use Highlight.

Not sure what search I did on the regressing bug to miss these.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/193d0be6ed5b
Fix some missing Highlight -> SelectedItem replacements. r=mstange
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

Comment on attachment 9240028 [details]
Bug 1729645 - Fix some missing Highlight -> SelectedItem replacements. r=mstange

Beta/Release Uplift Approval Request

  • User impact if declined: Wrong highlight colors in some parts of the UI.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix.
  • String changes made/needed: none
Flags: needinfo?(emilio)
Attachment #9240028 - Flags: approval-mozilla-beta?
Attachment #9240028 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.