Closed
Bug 1693710
Opened 3 years ago
Closed 3 years ago
Suppress notch on arrow panels when Proton is enabled
Categories
(Toolkit :: Themes, task)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-door-hangers])
Attachments
(1 file)
It's not clear to me if the easiest way to do this while maintaining the behaviour of the arrow panels is to just do this with CSS and make the notch display:none. It might also be possible to just not have these panels be arrow panels, but I think that changes some of their positioning characteristics.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → mconley
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•3 years ago
|
||
I've opted to suppress the arrow with CSS. Trying to maintain arrow panel behaviour without the type="arrow" attribute with Proton, while also keeping type="arrow" for when Proton is disabled is too complicated, and I'm opting for simplicity here.
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/efddcc63141e Suppress the notch on doorhangers if Proton doorhangers are enabled. r=Gijs
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
|
||
Updated•3 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
|
||
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-301
You need to log in
before you can comment on or make changes to this bug.
Description
•