1693778 - [RTL] URLs in the autocomplete view are left aligned

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Itiel]

Attachment: Screenshot

STR:

1. Latest Nightly, intl.uidirection set to 1 (or intl.l10n.pseudo set to bidi)
2. Type anything in the urlbar

AR:
The page name is on the right (good), but the url itself is aligned to the left (bad)

ER:
Both should be aligned to the right, while the URL itself is LTR.

Comment 1

[Itiel]

This is regressed by bug 1692526, but bugzilla crashes everytime I edit this bug accordingly, because I have no access to that bug.

Comment 2

[Drew Willcoxon :adw]

Thanks Itiel.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1693778 - [RTL] Properly right-align URLs in urlbar results now that their container is flexed.

Comment 4

[Drew Willcoxon :adw]

In your screenshot some of the result titles are faded out on their left edge: web.mit.edu, dummy.pdf, test speed, test camera. That... doesn't look right. Does that normally happen? Did that start happening with the misaligned URLs? I can't reproduce it.

Comment 5

[Itiel]

(In reply to Drew Willcoxon :adw from comment #4)

In your screenshot some of the result titles are faded out on their left edge: web.mit.edu, dummy.pdf, test speed, test camera. That... doesn't look right. Does that normally happen? Did that start happening with the misaligned URLs? I can't reproduce it.

This is a pre-existing issue, see bug 1599220.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b82a9735c6a7
[RTL] Properly right-align URLs in urlbar results now that their container is flexed. r=dao

Comment 7

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]: This is a big visual regression for RTL users. Please see comment 0. Fortunately the fix is simple.

Comment 8

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]: [I meant to track 87, not 88] This is a big visual regression for RTL users. Please see comment 0. Fortunately the fix is simple.

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b82a9735c6a7

Comment 10

[Drew Willcoxon :adw]

Comment on attachment 9204261 [details]
Bug 1693778 - [RTL] Properly right-align URLs in urlbar results now that their container is flexed.

Beta/Release Uplift Approval Request

• User impact if declined: RTL users will see misaligned URLs in the urlbar.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small CSS-only change that adds one rule for RTL users
• String changes made/needed:

Comment 11

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9204261 [details]
Bug 1693778 - [RTL] Properly right-align URLs in urlbar results now that their container is flexed.

approved for 87.0b2

Comment 12

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4bef3e266abe

Comment 13

[Petruta Horea [:phorea], PTO until 8/22/25]

Reproduced the issue on Firefox 87 beta 1.
Verified fixed using Firefox 87 beta 2 and Nightly 88.0a1 2021-02-23 under Win 10 64-bit and Ubuntu 18.04 64-bit.