1694027 - Highlights on scrollbar don't appear when searching in Bugzilla

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Calixte Denizet (:calixte)]

With firefox nightly (20210220213332):

STR:

• Open https://bugzilla.mozilla.org/show_bug.cgi?id=259640
• search for will and click on Highlight All

Results:

• we should have 6 marks but I've the impress that only one appears (or maybe the 6 into 1) on top of the scrollbar.

It works well in Chrome.

Comment 1

[Calixte Denizet (:calixte)]

I've the same issue on searchfox: https://searchfox.org/mozilla-central/source/toolkit/modules/FinderHighlighter.jsm
and search for window => no mark on the scrollbar (nor on top of it).

Comment 2

[Mike de Boer [:mikedeboer]]

Ah, this seems similar to the bug that was filed against the PDF viewer - bug 1693784. Neil, there might be value in somehow painting the marks on the main scrollbar AND the one on the box that has the largest scroll overflow? Or the range's scrollContainer (if such a thing exists).

Comment 3

[Neil Deakin]

Attachment: Bug 1694027, use the body's scrollHeight to compute the scroll area is it is available, r=mikedeboer

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/074b603302d7
use the body's scrollHeight to compute the scroll area is it is available, r=mikedeboer

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/074b603302d7

Comment 6

[Calixte Denizet (:calixte)]

The issue is fixed for bugzilla but it still doesn't work on searchfox (see https://bugzilla.mozilla.org/show_bug.cgi?id=1694027#c1).

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:enndeakin, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Neil Deakin]

Comment on attachment 9204708 [details]
Bug 1694027, use the body's scrollHeight to compute the scroll area is it is available, r=mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: The new in ff87 find scrollbar ticks don't appear in the correct locations on some popular sites (wikipedia, yandex, bugzilla, etc)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: (I verified this bug myself)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small low risk cosmetic code change
• String changes made/needed: No

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9204708 [details]
Bug 1694027, use the body's scrollHeight to compute the scroll area is it is available, r=mikedeboer

approved for 87.0b8

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/72083da73edb

Comment 11

[Daniel Bodea [:danibodea]]

Fixed in Nightly v88.0a1 from 2021-03-08 based on this comment.