1694168 - The page at agspares.co.nz is not loading items with ETP set to STRICT

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Raul Bucata]

Attachment: item.gif

Environment:
Operating system: Windows 10 Pro
Firefox version: :Firefox Nightly 87.0a1 (2021-02-22)

Preconditions:
ETP set to STRICT

Steps to reproduce:

1. Navigate to: https://agspares.co.nz/category/Super-Store-Tractor-Linkage-Pins-Lynch-Pins-R-Clips .
2. Click on the first item displayed.

Expected Behavior:
The item is loaded on a new page

Actual Behavior:
Redirect to product details is not performed.

Notes:

• Not reproducible with ETP set to STANDARD.

Comment 1

[Thomas Wisniewski [:twisniewski]]

They are doing this on product clicks:

function onProductClick( aLink ) {
  var product = {};
  product.id = $( aLink ).data( 'ref' );
  product.name = $( aLink ).data( 'name' );
  product.category = $( aLink ).data( 'category' );
  
  ga('ec:addProduct', product );
  ga('ec:setAction', 'click', {list: 'Search Results'});
  
  // Send click with an event, then send user to product page.
  ga('send', 'event', 'UX', 'click', 'Results', {
    hitCallback: function() {
      document.location =  $( aLink ).attr( 'href' );
    }
  });
  
  return false;
}

Our Google Analytics shim will need to support this properly (more info at https://developers.google.com/analytics/devguides/collection/analyticsjs/sending-hits).

Comment 2

[Thomas Wisniewski [:twisniewski]]

Actually, our shim was working, it was just not being applied because the page pre-defines their own window.ga object, so we just have to apply the shim in that case as well.

Additionally, they currently have a bug on their page where they're not loading Google Publisher Tags correctly (wrong URL, https://www.googletagmanager.com/gtm.jsid=GTM-M49K2L) which causes the page to take an extra few seconds to finish loading.

Comment 3

[Simona Badau, Desktop QA]

This issue is no longer reproducible on Nightly 92.0a1/93.0a1 nor on the latest Firefox 92 beta 1 - redirecting to the product's page is properly done. Tested in strict mode and private mode on macOS Big Sur 11.5, Ubuntu 20.04 x 64, and Windows 10 x64.

Tom, can this bug be closed?
Thanks!

Comment 4

[miralobontiu]

The issue doesn’t reproduce on 8/23 Nightly 93.0a1 build, nor in Beta 92.0.0-beta.6, with Lenovo Tab M10 (Android 10).
I'll close this as verified.