1694203 - Have RemoteAccessible and LocalAccessible share the same base class

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[Eitan Isaacson [:eeejay]]

This will allow polymorphism and unified code paths for remote/local cases.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1694203 - P1: Add Accessible and have LocalAccessible inherit from it. r?Jamie,morgan

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1694203 - P2: Add eNumericValue and eAction to generic types for use in proxy.

eHasNumericValue should probably not be a state anyway. We need both of
these types because we currently send eHasNumericValue and
ActionCount != 0 as interface flags when creating proxies.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1694203 - P3: Move type "Is" methods to Accessible base class. r?morgan,Jamie

This will allow remote accessibles to use them as well.

Depends on D104914

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1694203 - P4: Move IsTextRole from HyperTextAccessible to base class. r?morgan,Jamie

This will allow us to more easily query IsTextRole in remote case.

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1694203 - P5: Add and implement virtual hierarchy functions. r?morgan,Jamie

This allows us to use polymorphism when retrieving children/parents from
local or remote accessibles.

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1694203 - P7: Define IsLink as a virtual method in Accessible. r?morgan,Jamie

This may be enough and we can un-virtualize IsLink. But for now, this
allows remote accessibles to call IsLink.

Comment 7

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1694203 - P6: Virtualize Role() and implment in LocalAccessible. r?morgan,Jamie

Depends on D104926

Comment 8

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1694203 - P8: Rename ChildrenCount to ChildCount in RemoteAccessible. r?morgan,Jamie

This will allow us to make this an override when inheriting from Accessible.

Depends on D106004

Comment 9

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1694203 - P9: Have RemoteAccessible inherit from Accessible. r?morgan,Jamie

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/234e57a8ea1a
P1: Add Accessible and have LocalAccessible inherit from it. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/28f00d0ad7dc
P2: Add eNumericValue and eAction to generic types for use in proxy. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/f198d171958c
P3: Move type "Is" methods to Accessible base class. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/f542657c890d
P4: Move IsTextRole from HyperTextAccessible to base class. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/872cdb2e07bd
P5: Add and implement virtual hierarchy functions. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/9be66f33f6ec
P6: Virtualize Role() and implment in LocalAccessible. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/f5377ed40101
P7: Define IsLink as a virtual method in Accessible. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/52da6fbbb6db
P8: Rename ChildrenCount to ChildCount in RemoteAccessible. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/da6882bc37a7
P9: Have RemoteAccessible inherit from Accessible. r=Jamie

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/234e57a8ea1a
https://hg.mozilla.org/mozilla-central/rev/28f00d0ad7dc
https://hg.mozilla.org/mozilla-central/rev/f198d171958c
https://hg.mozilla.org/mozilla-central/rev/f542657c890d
https://hg.mozilla.org/mozilla-central/rev/872cdb2e07bd
https://hg.mozilla.org/mozilla-central/rev/9be66f33f6ec
https://hg.mozilla.org/mozilla-central/rev/f5377ed40101
https://hg.mozilla.org/mozilla-central/rev/52da6fbbb6db
https://hg.mozilla.org/mozilla-central/rev/da6882bc37a7