1694569 - Optimise memory usage for LocalAccessible/RemoteAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

With extra base classes (with virtual methods) comes more vtable pointers and thus more memory consumed. We should try to optimise this if possible. For example, perhaps we can avoid a vtable for the base class if all the virtual methods are pure virtual.

Comment 1

[Eitan Isaacson [:eeejay]]

Maybe a good first patch here would be to offer another A11YLOG flag for memory usage? I know there are a ton of memory tools in Gecko already, this wouldn't replace those. But this would give us a finer view of how much actual accessibilitrees, both remote and local, actually weigh.

Maybe there is a good way to do that with generic memory logging stuff. I just know them to be very slow and hard to parse out the accessibilitrees.

Also, extra bonus. If there was a version of this patch that can apply to a revision before bug 1694203 landed, we can get a picture of what our memory usage was before all this.

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1694569: Introduce tree size logging under A11YLOG r?eeejay,Jamie

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65fef67bf5d3
Introduce tree size logging under A11YLOG r=Jamie

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/65fef67bf5d3