1694264 - VCard version 4.0 does not use utf8 as default encoding

Status: RESOLVED FIXED

(Thunderbird :: Address Book, enhancement)

Description

[romain.pugin]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Created a Vcard version 4 with some non-ASCII characters (éà for example)

Actual results:

The characters were not imported properly.

Expected results:

The standard implementation of Vcard version 4 uses utf-8 by default. So these characters should have been imported properly

Comment 1

[Geoff Lankow (:darktrojan)]

Can confirm. Our core importing code is ancient history which is probably why.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1694264 - Teach nsIMsgVCardService about Unicode. r?mkmelin

Also removes nsAbContentHandler, which used this service but is now dead code.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/005e791b6a6b
Teach nsIMsgVCardService about Unicode. r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9204755 [details]
Bug 1694264 - Teach nsIMsgVCardService about Unicode. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): Never worked
User impact if declined: Some vCards with non-ASCII characters can't be read
Testing completed (on c-c, etc.): Landed two weeks ago
Risk to taking this patch (and alternatives if risky): Minimal

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9204755 [details]
Bug 1694264 - Teach nsIMsgVCardService about Unicode. r?mkmelin

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 87.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/dfa242019617

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9204755 [details]
Bug 1694264 - Teach nsIMsgVCardService about Unicode. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.9.0:
https://hg.mozilla.org/releases/comm-esr78/rev/ec7246d6f822

Comment 10

[Geoff Lankow (:darktrojan)]

Backed out and re-landed on 78 without the nsAbContentHandler removal:
https://hg.mozilla.org/releases/comm-esr78/rev/babe15289bb2
https://hg.mozilla.org/releases/comm-esr78/rev/3ce774768f70