1694481 - Remove Fennec code from GeckoAppShell

Status: RESOLVED FIXED

(GeckoView :: General, task, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

While looking at other bugs I noticed that we have a lot of Fennec code in GeckoAppShell and dependent files. So I went ahead and cleaned that up.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove unused telemetry methods.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Don't use androidBridge to determine if we're on Android.

androidBridge is an implementation detail that we want to eventually remove.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove fennec code in webcompat

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove Fennec code in nsIAndroidBridge.

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove unused android:// protocol handler

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove unused DirectBufferAllocator.

Comment 7

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove unused NativeZip.

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove unused methods in GeckoLoader.

Comment 9

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove unused code from exthandler/android.

Comment 10

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove unused methods in GeckoAppShell.

Comment 11

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove unused android lock screen orientation support.

Comment 12

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Simplify Android Listeners in GeckoAppShell.

GeckoAppShell has code to handle custom listeners, but we don't use them anymore.

Comment 13

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove GeckoAppShell.KillAnyZombies.

Before this patch, when the profile is locked on Android, we would call "ps",
parse the human-readable output and kill any other Gecko process that we could
find.

But this is completely unnecessary, as we know exactly that the PID of the
process holding the lock is.

In this patch we just kill the process holding the lock since this is
equivalent to the previous behavior.

Comment 14

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1694481 - Remove unused code in GeckoAppShell.

Comment 15

[Phabricator Automation]

Comment on attachment 9204935 [details]
Bug 1694481 - Remove GeckoAppShell.KillAnyZombies.

Revision D106186 was moved to bug 1697503. Setting attachment 9204935 [details] to obsolete.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d17eca939da
Remove unused telemetry methods. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/2e6cb8ba9f35
Don't use androidBridge to determine if we're on Android. r=whimboo,hiro
https://hg.mozilla.org/integration/autoland/rev/a2ef37064afa
Remove fennec code in webcompat r=webcompat-reviewers,denschub
https://hg.mozilla.org/integration/autoland/rev/1dd274370828
Remove Fennec code in nsIAndroidBridge. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/b87758d33be3
Remove unused android:// protocol handler r=aklotz
https://hg.mozilla.org/integration/autoland/rev/f56190277eaf
Remove unused DirectBufferAllocator. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/4ef4358255f9
Remove unused NativeZip. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/56983507ac02
Remove unused methods in GeckoLoader. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/7c8a32a8c126
Remove unused code from exthandler/android. r=droeh,esawin
https://hg.mozilla.org/integration/autoland/rev/e8790b8f8cdb
Remove unused methods in GeckoAppShell. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/934ce7e0aa44
Remove unused android lock screen orientation support. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/960307705ecd
Simplify Android Listeners in GeckoAppShell. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/710cb79b91f7
Remove unused code in GeckoAppShell. r=aklotz

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8d17eca939da
https://hg.mozilla.org/mozilla-central/rev/2e6cb8ba9f35
https://hg.mozilla.org/mozilla-central/rev/a2ef37064afa
https://hg.mozilla.org/mozilla-central/rev/1dd274370828
https://hg.mozilla.org/mozilla-central/rev/b87758d33be3
https://hg.mozilla.org/mozilla-central/rev/f56190277eaf
https://hg.mozilla.org/mozilla-central/rev/4ef4358255f9
https://hg.mozilla.org/mozilla-central/rev/56983507ac02
https://hg.mozilla.org/mozilla-central/rev/7c8a32a8c126
https://hg.mozilla.org/mozilla-central/rev/e8790b8f8cdb
https://hg.mozilla.org/mozilla-central/rev/934ce7e0aa44
https://hg.mozilla.org/mozilla-central/rev/960307705ecd
https://hg.mozilla.org/mozilla-central/rev/710cb79b91f7

Comment 19

[Mike Hommey [:glandium]]

Attachment: Extra cleanup after bug 1694481

There is no need to build Zip.cpp anymore when the linker is not
enabled, because nsGeckoUtils.cpp doesn't actually use it anymore.

Comment 20

[Phabricator Automation]

Comment on attachment 9372402 [details]
Extra cleanup after bug 1694481

Revision D198349 was moved to bug 1874348. Setting attachment 9372402 [details] to obsolete.