Missing RTL support for the Profiler, when opened from about:debugging
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)
Tracking
(firefox88 fixed)
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: itiel_yn8, Assigned: jdescottes)
References
Details
(Keywords: rtl)
Attachments
(2 files)
Screenshot
What were you doing?
- Set
intl.l10n.pseudotobidiand restart - Open about:debugging
- Connect to a device
- Click the Performance profile button
What happened?
The embedded iframe is in LTR.
What should have happened?
Should have been RTL.
|
Assignee | |
Comment 1•3 years ago
|
||
Julien, we should probably not show the onboarding UI for the profiler in about:debugging, do we have another bug tracking this already? Thanks
|
||
Comment 2•3 years ago
|
||
ah I remember I wanted to file this indeed, but I can't find any existing bug. I totally agree with you. I filed Bug 1694970.
That said, the whole panel doesn't seem RTL-friendly in this setup, not only the onboarding. I believe we'll need to set dir and lang. Should that come from the panel itself, or is it set from the about:debugging page when adding the iframe? In the devtools toolbox I believe this is handled by the toolbox, right?
|
|
Assignee | |
Comment 3•3 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #2)
ah I remember I wanted to file this indeed, but I can't find any existing bug. I totally agree with you. I filed Bug 1694970.
That said, the whole panel doesn't seem RTL-friendly in this setup, not only the onboarding. I believe we'll need to set
dirandlang. Should that come from the panel itself, or is it set from the about:debugging page when adding the iframe? In the devtools toolbox I believe this is handled by the toolbox, right?
Thanks for filing the other bug! You're right, the whole panel is not following the about:debugging dir/lang. And the toolbox is indeed responsible for that so it would make sense that about debugging is responsible for setting those attributes properly as well.
https://searchfox.org/mozilla-central/rev/002023eb262be9db3479142355e1675645d52d52/devtools/client/framework/toolbox.js#2576
Repurposing.
|
|
Assignee | |
Comment 4•3 years ago
|
||
When opening the profiler dialog iframe, set the contentWindow.document direction based on the direction from the aboutdebugging document.
Add a test to check rtl is correctly set as the document direction for both about:debugging and the profiler dialog documents.
|
||
Updated•3 years ago
|
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3aeff03dbf40 [devtools] Set correct document direction for about:debugging's profiler dialog r=ladybenko
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Description
•