1694745 - [Hikari] Firefox Nightly refresh frontend only on window focus with wayland

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P2)

Description

[Mike Powell]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Start firefox-nightly under wayland after updates (2021-02-11) are installed.

Actual results:

The firefox frontend will only refresh the view, after a new focus of the window.
This only happens with wayland. Under x11/xwayland firefox nightly runs well.

Expected results:

Firefox should render the frontend.

I run mozregression to check the changes.

15:53.78 INFO: Last good revision: b0615d0577ae4f0ca373b122b74c8da14cb7dc3a
15:53.78 INFO: First bad revision: e1e5bb1b3ccf4021ab9b54a1fd4153ad3ab624c9
15:53.78 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b0615d0577ae4f0ca373b122b74c8da14cb7dc3a&tochange=e1e5bb1b3ccf4021ab9b54a1fd4153ad3ab624c9

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Which Wayland compositor do you run?

Comment 3

[Mike Powell]

Hi, I use hikari (https://hikari.acmelabs.space/)

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Okay, Thanks.

Comment 5

[Narrat]

Not sure if the bisected commit made it into the release, but with Firefox 87 I got hit by this too. Therefore this comment for those who experience the same, but not with the nightly version.

Comment 6

[Mike Powell]

Since this bug was ported to FF 87, I can confirm same problems on labwc compositor. Firefox runs only well if I move the cursor.
Still happens in FF 89.

Comment 7

[Robert Mader [:rmader]]

As this has been reported on FF 87, it sounds a lot like bug 1616894. In that case it should have started with bug 1629140 / https://hg.mozilla.org/integration/autoland/rev/9658708ceaea - can anybody confirm?

If that's the case, then it's a compositor bug and needs to get fixed there.

Comment 8

[Robert Mader [:rmader]]

FTR: this can be trivially tested by disabling widget.wayland_vsync.enabled in about:config (needs a restart).

Comment 9

[Mike Powell]

Didn't worked for me in nightly, din't work for me in 87.

Comment 10

[gabriel+mozilla]

widget.wayland_vsync.enabled is the default in FF 87, and the problem still happens (under wayland/hikari) - I tried flipping that to false, and restarting, but the problem is still there.

Comment 11

[Mike Powell]

Also still happens in labwc with widget.wayland_vsync.enabled = false.

Comment 12

[Robert Mader [:rmader]]

Thanks for trying! Does enabling webrender make a difference? gfx.webrender.all

Comment 13

[gabriel+mozilla]

Tried webrender on/off, and makes no difference either. I often run with webrender on owing to another bug.

Comment 14

[Robert Mader [:rmader]]

As this issue is apparently compositor specific, can anyone affected open a issue at the compositors in question and link it here? Or got it better by now?

Comment 15

[gabriel+mozilla]

Robert, for hikari this was fixed, so the situation is considerably better. However, hikari and sway both suffer from flickering on things like right-click menus, bookmark folders from toolbars, etc.. I am not sure this is related, I hear that it may be due to damage tracking, but can't really add too much more.

Comment 16

[Robert Mader [:rmader]]

Thanks Gabriel! In Sway the main cause for flickering was recently fixed (bug 1696662 / https://github.com/swaywm/sway/pull/6046) - so also a compositor bug and Hakari will hopefully port that over soon (if not, please make them aware of that PR).

As the main issue here is fixed, I'll close this.