Closed Bug 1696662 Opened 2 years ago Closed 2 years ago

[Wayland][Sway] Popup menu flickers

Categories

(Core :: Widget: Gtk, defect, P3)

Unspecified
Linux
defect

Tracking

()

RESOLVED MOVED
Tracking Status
firefox88 --- affected

People

(Reporter: kevin, Unassigned)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

Using Firefox Nightly 88.0a1 (2021-03-05) (64-bit) on sway with MOZ_ENABLE_WAYLAND=1, popups (right-click popup, HTML drop-downs, FF main menu, bookmarks toolbar folders, etc.) flicker. The flicker occurs intermittently, most often when a popup is first opened, when the mouse moves, or when the popup covers dynamic content (e.g. video). The flicker can be significant enough to make menu items difficult to read and select. Attached video demonstrates the flickering. Mozregression:

Last good revision: 8a964fae4408a2710696df83c1e34388801f484c
First bad revision: 29a6032df4108887a29d11301c6151fe2a9b956c
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8a964fae4408a2710696df83c1e34388801f484c&tochange=29a6032df4108887a29d11301c6151fe2a9b956c

Which suggests it was regressed by the fix for Bug 1644018. My apologies for not mentioning it earlier. I had noticed the flickering but only recently had the time to investigate and bisect.

Blocks: wayland-sway
Priority: -- → P3

What version of sway are you running? I believe this was fixed in sway master, via https://github.com/swaywm/sway/pull/6046.

(In reply to Tudor from comment #1)

What version of sway are you running? I believe this was fixed in sway master, via https://github.com/swaywm/sway/pull/6046.

The issue occurs for me using the Debian sway package version 1.5-7 and 1.5.1-2. I am unable to compile sway master (d358aab8) due to "WLR_HAS_XDG_FOREIGN is not defined". (Presumably libwlroots-dev 0.12.0-2 is insufficient and an unreleased version is required?) I'd be happy to test once binaries are available.

Indeed, you typically need the latest wlroots to compile the latest sway. See https://github.com/swaywm/sway/wiki/Development-Setup#compiling-as-a-subproject for instructions on building sway alongside wlroots. Otherwise, the change will be part of the upcoming 1.6 release.

(In reply to Tudor from comment #3)

Indeed, you typically need the latest wlroots to compile the latest sway. See https://github.com/swaywm/sway/wiki/Development-Setup#compiling-as-a-subproject for instructions on building sway alongside wlroots. Otherwise, the change will be part of the upcoming 1.6 release.

Thanks. I was able to build sway and can confirm that the issue appears to be fixed. I'm unable to reproduce the flickering using sway master (d358aab8).

With sway-1.6-rc1 the popup does not flicker constantly as it used to, but I still see a bit of flickering for a second when the popup opens.

(In reply to sorrow from comment #5)

With sway-1.6-rc1 the popup does not flicker constantly as it used to, but I still see a bit of flickering for a second when the popup opens.

A certain flicker on first opening is unfortunately still expected, on all compositors, and there're some other bugs for it. Closing this one as the main issue was reported to be fixed in sway.

Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → MOVED
You need to log in before you can comment on or make changes to this bug.