1694797 - The search box is not full width

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Arthur K. (he/him)]

Attachment: tiny-search-bar.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

Testing with the candidate build of 87.0b and I went to search for an email.

Actual results:

I noticed the search box field is no longer the full width between the "Contains" parameter and the "Add a new rule" [+] button. It's very tiny now.

Expected results:

Was full width in 86.0b3.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1694797-searchDialog-CSS-fixes.patch landed in comment 4

We need the same flex rules after bug 1689876 on the AB-/Message search dialogs.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9205316 [details] [diff] [review]
1694797-searchDialog-CSS-fixes.patch landed in comment 4

Review of attachment 9205316 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9205316 [details] [diff] [review]
1694797-searchDialog-CSS-fixes.patch landed in comment 4

[Approval Request Comment]
Regression caused by (bug #): 1689876
User impact if declined: input fields/menulists too short in search dialogs
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6dca09c87e42
Follow in search dialog the changes from bug 1689876. r=mkmelin

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9205316 [details] [diff] [review]
1694797-searchDialog-CSS-fixes.patch landed in comment 4

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 87.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/c51f65b31f56

Comment 7

[WaltS48 [:walts48]]

Name Thunderbird
Version 87.0b2-de
Build-ID 20210302182637

Looks okay to me in release candidate testing on Windows 10.

Comment 8

[Arthur K. (he/him)]

Attachment: incorrect-height.png

(In reply to WaltS48 [:walts48] from comment #7)

Name Thunderbird
Version 87.0b2-de
Build-ID 20210302182637

Looks okay to me in release candidate testing on Windows 10.

Close, but not quite.

Comment 9

[WaltS48 [:walts48]]

Well, I never use it so you are now the authority and can verify when it is properly resolved.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1694797-search-textbox-taller.patch

This makes the search-value-textbox taller on Windows. This are the only such textboxes that are in a row with menulists and needs an adaption in height.

Comment 11

[Alessandro Castellani [:aleca]]

Comment on attachment 9206957 [details] [diff] [review]
1694797-search-textbox-taller.patch

Review of attachment 9206957 [details] [diff] [review]:
-----------------------------------------------------------------

Tested in a VM and it looks good, thanks.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8cc87284bac7
Make on Windows the search-value-textbox taller. r=aleca