The search box is not full width
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird_esr78 unaffected, thunderbird87 fixed, thunderbird88 affected)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | unaffected |
thunderbird87 | --- | fixed |
thunderbird88 | --- | affected |
People
(Reporter: thee.chicago.wolf, Assigned: Paenglab)
References
(Regression)
Details
(Keywords: regression)
Attachments
(4 files)
4.16 KB,
image/png
|
Details | |
4.81 KB,
patch
|
mkmelin
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
14.63 KB,
image/png
|
Details | |
1.30 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0
Steps to reproduce:
Testing with the candidate build of 87.0b and I went to search for an email.
Actual results:
I noticed the search box field is no longer the full width between the "Contains" parameter and the "Add a new rule" [+] button. It's very tiny now.
Expected results:
Was full width in 86.0b3.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
We need the same flex rules after bug 1689876 on the AB-/Message search dialogs.
Comment 2•4 years ago
|
||
Comment on attachment 9205316 [details] [diff] [review] 1694797-searchDialog-CSS-fixes.patch landed in comment 4 Review of attachment 9205316 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! r=mkmelin
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
Comment on attachment 9205316 [details] [diff] [review]
1694797-searchDialog-CSS-fixes.patch landed in comment 4
[Approval Request Comment]
Regression caused by (bug #): 1689876
User impact if declined: input fields/menulists too short in search dialogs
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/6dca09c87e42
Follow in search dialog the changes from bug 1689876. r=mkmelin
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Comment on attachment 9205316 [details] [diff] [review]
1694797-searchDialog-CSS-fixes.patch landed in comment 4
[Triage Comment]
Approved for beta
Comment 6•4 years ago
|
||
bugherder uplift |
Thunderbird 87.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/c51f65b31f56
Comment 7•4 years ago
|
||
Name Thunderbird
Version 87.0b2-de
Build-ID 20210302182637
Looks okay to me in release candidate testing on Windows 10.
Reporter | ||
Comment 8•4 years ago
|
||
(In reply to WaltS48 [:walts48] from comment #7)
Name Thunderbird
Version 87.0b2-de
Build-ID 20210302182637Looks okay to me in release candidate testing on Windows 10.
Close, but not quite.
Comment 9•4 years ago
|
||
Well, I never use it so you are now the authority and can verify when it is properly resolved.
Assignee | ||
Comment 10•4 years ago
|
||
This makes the search-value-textbox taller on Windows. This are the only such textboxes that are in a row with menulists and needs an adaption in height.
Assignee | ||
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Comment on attachment 9206957 [details] [diff] [review] 1694797-search-textbox-taller.patch Review of attachment 9206957 [details] [diff] [review]: ----------------------------------------------------------------- Tested in a VM and it looks good, thanks.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/8cc87284bac7
Make on Windows the search-value-textbox taller. r=aleca
Description
•