1694882 - WebExtension alerts should show the extension name as the origin

Status: VERIFIED FIXED

(Firefox :: General, enhancement, P2)

Description

[Yanfang Liu]

Attachment: alert dialog

Tested with Firefox 87b2 on Windows 10 x64.

STR:

1. Install Firefox 87b2 (In early beta, prompts.contentPromptSubDialog = true).
2. Install COBA addon to Firefox.
3. Open http://www.icbc.com.cn/icbc/, click 'Open in Internet Explorer'.
4. Check the alert dialog.

Actual results:
The alert dialog dosen't look good after showing origin.

Could we display the extension name instead of the origin text?

Comment 1

[:Gijs (he/him)]

We need to update the title anyway after bug 1693008 lands (and remove the "says" bits, only showing the origin), so I guess we could tackle it there.

Comment 2

[:Gijs (he/him)]

Isn't this also reproducible prior to the proton changes? In particular, we already show the origin if the website is framed into a page with a different origin, so I'd expect that invoking it from

data:text/html,<iframe src="http://www.icbc.com.cn/icbc/" height=900 width=900>

would already have this issue in release.

Note that I cannot see where to click "Open in Internet Explorer" even if I add the add-on.

Comment 3

[Yanfang Liu]

(In reply to :Gijs (he/him) from comment #2)

Isn't this also reproducible prior to the proton changes? In particular, we already show the origin if the website is framed into a page with a different origin, so I'd expect that invoking it from

data:text/html,<iframe src="http://www.icbc.com.cn/icbc/" height=900 width=900>

would already have this issue in release.

As I know, the extension doesn't handle the framed websites:
https://github.com/MozillaOnline/COBA/blob/develop/webextension/background.js#L447-L450

Note that I cannot see where to click "Open in Internet Explorer" even if I add the add-on.

Open http://www.icbc.com.cn/icbc/ directly in the URL bar, can you see "Open in Internet Explorer" in the page?

Comment 4

[:Gijs (he/him)]

(In reply to Yanfang Liu from comment #3)

(In reply to :Gijs (he/him) from comment #2)

Isn't this also reproducible prior to the proton changes? In particular, we already show the origin if the website is framed into a page with a different origin, so I'd expect that invoking it from

data:text/html,<iframe src="http://www.icbc.com.cn/icbc/" height=900 width=900>

would already have this issue in release.

As I know, the extension doesn't handle the framed websites:
https://github.com/MozillaOnline/COBA/blob/develop/webextension/background.js#L447-L450

Sure, maybe the COBA extension doesn't, but the overall problem is not unique to that extension...

Note that I cannot see where to click "Open in Internet Explorer" even if I add the add-on.

Open http://www.icbc.com.cn/icbc/ directly in the URL bar, can you see "Open in Internet Explorer" in the page?

Nope. Maybe because I'm on macOS?

Comment 5

[:Gijs (he/him)]

Update priority to reflect proton priorities.

Comment 6

[Hector Zhao [:hectorz]]

Attachment: Bug 1694882 - WebExtension alerts should show the extension name as the origin. r?Gijs

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/434d0ca77a5e
WebExtension alerts should show the extension name as the origin. r=Gijs

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/434d0ca77a5e

Comment 9

[Yanfang Liu]

Verified as fixed on the latest Firefox Nightly 88.0a1 (2021-03-07).