1694901 - Differences in headers generated from ipdl depending on python version

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Mike Hommey [:glandium]]

Attachment: diff.txt

(filing as a defect because it's making it more difficult for me to attest whether my build environment changes on automation are affecting the resulting binaries or not)

For some reason, there are differences in PNeckoChild.h and PNeckoParent.h (and only those) when running the ipdl generator with python 3.6 vs. 3.7. Diffoscope output attached.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

It looks like the friends declarations are generated as part of this iteration in lower.py: for friend in friends:. I saw something about how dicts are insertion ordered starting in 3.7, but I guess sets still aren't, so the iteration order is not specified? I guess the fix here is to turn the set into a list and sort it, or something. (I didn't notice that you'd already assigned yourself before I started looking at this, so I'll just leave this here.)

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1694901 - Generate ipdl headers more deterministically.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19890824a703
Generate ipdl headers more deterministically. r=mccr8

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/19890824a703