1694936 - Some <description> tags display differently in the identity panel

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Tim Nguyen :ntim]

Attachment: Screenshot of one of broken <description> tags

Before bug 1590884, <description> tag had a display value (which we determined as being display: flow-root) that was overriding whatever other CSS set (unless it was display: none).

Now: https://searchfox.org/mozilla-central/rev/df23c6e58c6be1eb8399e475878f73d4867bef87/browser/themes/shared/controlcenter/panel.inc.css#55-81

is overriding display: flow-root with display: inherit giving it wrong line-wrapping behaviour.

Comment 1

[Tim Nguyen :ntim]

I expect this bug to fix bug 1694731 as well.

Comment 2

[Emma Zühlcke [:emz]]

I think this is an S2 since we cut off some security labels. We should fix it as soon as possible.
Tim, could you take this? As we discussed on Matrix, setting display: revert should fix the issue.

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1694936 - Fix appearance of some <description> tags in identity panel. r=pbz

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2afdd8e27ee8
Fix appearance of some <description> tags in identity panel. r=pbz

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2afdd8e27ee8

Comment 6

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

Hello! Can someone please help me with some STR in order to manually reproduce/verify the issue? Unfortunately, I didn't found a way to display that message under the Connection secure. Thank you!

Comment 7

[Emma Zühlcke [:emz]]

You can test the issue on https://very.badssl.com/. The description "<appname> has blocked parts of this page that are not secure" should be affected by this bug.

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

Attachment: secure_tags

Unfortunately, the tag message is not cut off with the affected version either. Or should I look only for the color display like in the latest Nightly (e.g: link)?

Comment 9

[Emma Zühlcke [:emz]]

It should affect all descriptions that are long enough so they wrap. I just tested the issue successfully by reverting the patch locally (based on central).
Perhaps the broken state was never in Nightly? I can see that the regressing Bug 1590884 landed a day before the fix landed.
Can you see if you can reproduce with the Nightly the day before / after?

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

Attachment: 24th

On 24'th I can see that the string is displayed on one row. So maybe that this is broken but the string is not long enough to be cut off?
On 26'th the string is displayed the same as in 25.
Thank you!

Comment 11

[Emma Zühlcke [:emz]]

(In reply to Alexandru Trif, QA [:atrif] from comment #10)

Created attachment 9215083 [details]
24th

On 24'th I can see that the string is displayed on one row. So maybe that this is broken but the string is not long enough to be cut off?
On 26'th the string is displayed the same as in 25.
Thank you!

From the screenshot it looks like this build is affected by the bug. You can see how the description tag pushes the > button out of the panel on the right side. While it's not long enough to be cut off it clearly breaks the UI the same way by not wrapping to the next line. Verifying with this would work for me.

Edit: I can also see the label cutoff with the first FF run of mach mozregression --good 2021-02-24.

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

(In reply to Paul Zühlcke [:pbz] from comment #11)

(In reply to Alexandru Trif, QA [:atrif] from comment #10)

Created attachment 9215083 [details]
24th

On 24'th I can see that the string is displayed on one row. So maybe that this is broken but the string is not long enough to be cut off?
On 26'th the string is displayed the same as in 25.
Thank you!

From the screenshot it looks like this build is affected by the bug. You can see how the description tag pushes the > button out of the panel on the right side. While it's not long enough to be cut off it clearly breaks the UI the same way by not wrapping to the next line. Verifying with this would work for me.

Edit: I can also see the label cutoff with the first FF run of mach mozregression --good 2021-02-24.

Thank you, Paul! Verified fixed with Firefox 88.0b9 on Windows 10x64, macOS 11.2.3 and Ubuntu 20.04. The <description> tags are properly arranged and not breaking the UI when longer strings are displayed.