1695082 - Update copy for permission panel: WebRTC

Status: RESOLVED FIXED

(Firefox :: Site Permissions, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

We're still waiting on what the exact strings are, but this bug will be updated as soon as we have them.

Don't bother converting the strings to Fluent. Just update the .properties file, and make sure to rev the string ID.

The code powering the WebRTC device permission panel is here: https://searchfox.org/mozilla-central/rev/6f8f3d0e9022b6f0405da26ec940a89455416202/browser/actors/WebRTCParent.jsm#416

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Okay, strings are in:

Here are the strings: https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties#726-733 and https://searchfox.org/mozilla-central/rev/362676fcadac37f9f585141a244a9a640948794a/browser/locales/en-US/browser/browser.ftl#393-394

• getUserMedia.shareCamera2.message should be changed to: Allow %S to use your camera?

• getUserMedia.shareMicrophone2.message should be changed to: Allow %S to use your microphone?

• getUserMedia.shareScreen3.message should be changed to Allow %S to see your screen?

• getUserMedia.shareCameraAndMicrophone2.message should be changed to Allow %S to use your camera and microphone?

• getUserMedia.shareCameraAndAudioCapture2.message should be changed to Allow %S to use your camera and listen to this tab’s audio?

• getUserMedia.shareScreenAndMicrophone3.message should be changed to Allow %S to use your microphone and see your screen?

• getUserMedia.shareScreenAndAudioCapture3.message should be changed to Allow %S to listen to this tab’s audio and see your screen?

• getUserMedia.shareAudioCapture2.message should be changed to Allow %S to listen to this tab’s audio?

• getUserMedia.shareScreen.learnMoreLabel should have its casing changed to be "Learn more". This does not require the ID to be rev'd.

• getUserMedia.selectWindowOrScreen.label should be changed to Window or screen:

• getUserMedia.dontAllow.label should be changed to Block

• getUserMedia.dontAllow.accesskey should be changed to B

• popup-silence-notifications-checkbox should be changed to Mute website notifications while sharing

We should also remove the popup-silence-notifications-checkbox-warning string, and not display a warning when the muting checkbox is checked.

• Here, the .value should be changed to Camera:
• Here, the .value should be changed to Microphone:

We also want to update these strings:

• getUserMedia.shareCameraUnsafeDelegation.message should be changed to Allow %1$S to give %2$S access to your camera?
• getUserMedia.shareMicrophoneUnsafeDelegations.message should be changed to Allow %1$S to give %2$S access to your microphone?
• getUserMedia.shareScreenUnsafeDelegation.message should be changed to Allow %1$S to give %2$S permission to see your screen?
• getUserMedia.shareCameraAndMicrophoneUnsafeDelegation.message should be changed to Allow %1$S to give %2$S access to your camera and microphone?
• getUserMedia.shareCameraAndAudioCaptureUnsafeDelegation.message should be changed to Allow %1$S to give %2$S access to your camera and listen to this tab’s audio?
• getUserMedia.shareScreenAndMicrophoneUnsafeDelegation.message should be changed to Allow %1$S to give %2$S access to your microphone and see your screen?
• getUserMedia.shareScreenAndAudioCaptureUnsafeDelegation.message should be changed to Allow %1$S to give %2$S permission to listen to this tab’s audio and see your screen?
• getUserMedia.pickWindowOrScreen.label should be changed to Select window or screen. This does not require the ID to be rev'd.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

We should also remove the popup-silence-notifications-checkbox-warning string, and not display a warning when the muting checkbox is checked.

This is being done in bug 1696991.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Having consulted with tduzan and betsymikal, we're also changing the screen share secondary action strings from "Not Now" and "Never Allow" to "Block" and "Always Block", respectively.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1695082 - Update WebRTC permission panel copy. r?flod!,pbz!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12dd9dce97f9
Update WebRTC permission panel copy. r=flod,pbz,fluent-reviewers

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/12dd9dce97f9

Comment 7

[Timea Cernea [:tbabos][inactive]]

QA verified the strings for the WebRTC Permission panel to match the changes on:

• Firefox Nightly 88
• Firefox Beta 88

Covered Platforms:

• Windows 7/10
• MacOS 10.15
• Ubuntu 20.04

Not marking this is verified-fixed given it contains string from other panels as well.