1695404 - Support the type() function in image-set

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Emilio Cobos Álvarez (:emilio)]

https://drafts.csswg.org/css-images-4/#funcdef-image-set-type.

We need to tweak the struct here to add two members, something like:

has_type: bool,
type: crate::OwnedStr,

The reason to do this rather than using Option<String> or something more rusty is that otherwise the type wouldn't be ffi-compatible.

Then we need to parse it around here and set that appropriately.

Then in the selection code we need to account for that passing the type to do a function like this, and check that all is thread-safe.

For now, we can probably live with trying to select one image if all images are invalid. Further steps could be teaching the image-set code to deal with no image being selected at all, but that seems not necessary really.

Comment 1

[Pierre TALLOTTE]

I'll work on it.

Comment 2

[Pierre TALLOTTE]

Attachment: Bug 1695404 - Support the type() function in image-set. r?emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fa9c71b33b2
Support the type() function in image-set. r=emilio

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28554 for changes under testing/web-platform/tests

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4fa9c71b33b2

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1695404 - follow-up: Avoid redundant string copy in Gecko_IsSupportedImageMimeType. r=tnikkel,aosmond

There's no reason to require a null-terminated string in imgLoader.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12df1f94f215
follow-up: Avoid redundant string copy in Gecko_IsSupportedImageMimeType. r=tnikkel

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/12df1f94f215

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2cd12b4884b8
adjust imgLoader::SupportImageWithMimeType call in libmime for changes in bug 1695404. rs=bustage-fix

Comment 10

[Tom S [:evilpie]]

Attachment: Bug 1695404 - follow-up: More tiny cleanup. r?emilio

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2bdd3e5f1a3
follow-up: More tiny cleanup. r=emilio

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b2bdd3e5f1a3

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Rachel Andrew]

Release notes, BCD and syntax data updated, and docs written.