Closed Bug 1695409 Opened 3 years ago Closed 3 years ago

Disabled sound file in preferences not readable with dark theme

Categories

(Thunderbird :: Theme, task)

Tracking

(thunderbird_esr78 fixed, thunderbird87 fixed, thunderbird88 affected)

RESOLVED FIXED
88 Branch
Tracking Status
thunderbird_esr78 --- fixed
thunderbird87 --- fixed
thunderbird88 --- affected

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

In the preferences under General the sound file URL is unreadable when it's disabled with dark theme.

I removed all code that is set by common.css or in the platform input-fields.css and thus unneeded.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9205872 - Flags: review?(alessandro)
Comment on attachment 9205872 [details] [diff] [review]
1695409-remove-unneeded-input-filefield-rules.patch

Review of attachment 9205872 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #9205872 - Flags: review?(alessandro) → review+
Target Milestone: --- → 88 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c262301af0f4
Remove unneeded input-filefield rules. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Comment on attachment 9205872 [details] [diff] [review]
1695409-remove-unneeded-input-filefield-rules.patch

[Approval Request Comment]
User impact if declined: unreadable disabled file input fields with dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9205872 - Flags: approval-comm-beta?

[Approval Request Comment]
User impact if declined: unreadable disabled file input fields with dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9206269 - Flags: approval-comm-esr78?

Comment on attachment 9205872 [details] [diff] [review]
1695409-remove-unneeded-input-filefield-rules.patch

[Triage Comment]
Approved for beta

Attachment #9205872 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9206269 [details] [diff] [review]
1695409-remove-unneeded-input-filefield-rules-ESR.patch

[Triage Comment]
Approved for esr78

Attachment #9206269 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: