Disabled sound file in preferences not readable with dark theme
Categories
(Thunderbird :: Theme, task)
Tracking
(thunderbird_esr78 fixed, thunderbird87 fixed, thunderbird88 affected)
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(2 files)
3.05 KB,
patch
|
aleca
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
3.08 KB,
patch
|
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
In the preferences under General the sound file URL is unreadable when it's disabled with dark theme.
Assignee | ||
Comment 1•3 years ago
|
||
I removed all code that is set by common.css or in the platform input-fields.css and thus unneeded.
Comment 2•3 years ago
|
||
Comment on attachment 9205872 [details] [diff] [review] 1695409-remove-unneeded-input-filefield-rules.patch Review of attachment 9205872 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c262301af0f4
Remove unneeded input-filefield rules. r=aleca
Assignee | ||
Comment 4•3 years ago
|
||
Comment on attachment 9205872 [details] [diff] [review]
1695409-remove-unneeded-input-filefield-rules.patch
[Approval Request Comment]
User impact if declined: unreadable disabled file input fields with dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Assignee | ||
Comment 5•3 years ago
|
||
[Approval Request Comment]
User impact if declined: unreadable disabled file input fields with dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Comment 6•3 years ago
|
||
Comment on attachment 9205872 [details] [diff] [review]
1695409-remove-unneeded-input-filefield-rules.patch
[Triage Comment]
Approved for beta
Comment 7•3 years ago
|
||
bugherder uplift |
Thunderbird 87.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/898fd099c4c8
Comment 8•3 years ago
|
||
Comment on attachment 9206269 [details] [diff] [review]
1695409-remove-unneeded-input-filefield-rules-ESR.patch
[Triage Comment]
Approved for esr78
Comment 9•3 years ago
|
||
bugherder uplift |
Thunderbird 78.9.0:
https://hg.mozilla.org/releases/comm-esr78/rev/6e6d62c6ae14
Description
•