1695497 - the new tooltips look odd on Linux

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

The new tooltips look odd on Fedora 33 / Gnome.
The text size seem to be too large and the background color of the tooltip is too light, almost white I think. And somehow the tooltip is too packed. Perhaps it should have some more spacing around the text.
I have browser.proton.enabled and browser.proton.tabs.enabled enabled.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Bug 1665390 might have regressed this.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1665390

Comment 3

[Dão Gottwald [:dao]]

Attachment: Screenshot from Ubuntu

(In reply to Olli Pettay [:smaug] from comment #0)

The new tooltips look odd on Fedora 33 / Gnome.
The text size seem to be too large

I suspect this is based on mockups that were created for macOS which has varying default font sizes for different UI parts. Linux and Windows don't have that, and the default size seems fine; we probably don't need to mess with that.

and the background color of the tooltip is too light, almost white I think.

This looks particularly out of place on Ubuntu where native tooltips have a black background. I think we should generally continue to use native tooltips, and these new ones should fall in line.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1695497 - Fix Proton Places tooltip appearance on Linux and High Contrast. r=jaws

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/856229da4209
Fix Proton Places tooltip appearance on Linux and High Contrast. r=jaws

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/856229da4209