1695644 - when forwarding message with many attachments, the compose attachment area is just one row and doesn't have scrollbar

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P2)

Description

[Magnus Melin [:mkmelin]]

When I try to forward a message with a few pdfs attached, I get a compose window where the attachments area is just row. It doesn't have scrollbar either.
Toggling open/closed doesn't change it. Only one "line" or "row" shown.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1695644-attachments-forward.diff

This fixes it.
Pretty silly mistake of not assigning a default number value to the variable holding the bucket height value.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9206223 [details] [diff] [review]
1695644-attachments-forward.diff

Review of attachment 9206223 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! r=mkmelin

Comment 3

[Magnus Melin [:mkmelin]]

I notice the first click on the toggle arrow after you press forward, that doesn't do anything. Only from the second click the area toggles closed.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1695644-attachments-forward.diff

Found the problem with the double click to collapse.
The "toggle" action checks if the bucket was opened but unfocused. We do that to allow users to use the shortcut to focus on an open bucket and interact with the attachments via keyboard.
I updated the click method to always trigger the right show/hide action.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9206430 [details] [diff] [review]
1695644-attachments-forward.diff

Review of attachment 9206430 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thx! r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c07c005869b9
Expand attachment pane when forwarding a message with multiple attachments. r=mkmelin

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9206430 [details] [diff] [review]
1695644-attachments-forward.diff

[Triage Comment]
Prerequisite for bug 1695521 and bug 1695644 per aleca.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 87.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/21e00b8f1c2d