Closed Bug 1695644 Opened 7 months ago Closed 7 months ago

when forwarding message with many attachments, the compose attachment area is just one row and doesn't have scrollbar

Categories

(Thunderbird :: Message Compose Window, defect, P2)

Tracking

(thunderbird_esr78 unaffected, thunderbird87+ fixed)

RESOLVED FIXED
88 Branch
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird87 + fixed

People

(Reporter: mkmelin, Assigned: aleca)

References

(Regression)

Details

Attachments

(1 file, 1 obsolete file)

When I try to forward a message with a few pdfs attached, I get a compose window where the attachments area is just row. It doesn't have scrollbar either.
Toggling open/closed doesn't change it. Only one "line" or "row" shown.

Severity: -- → S2
Priority: -- → P2
Assignee: nobody → alessandro
Status: NEW → ASSIGNED
Attached patch 1695644-attachments-forward.diff (obsolete) — Splinter Review

This fixes it.
Pretty silly mistake of not assigning a default number value to the variable holding the bucket height value.

Attachment #9206223 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9206223 [details] [diff] [review]
1695644-attachments-forward.diff

Review of attachment 9206223 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! r=mkmelin
Attachment #9206223 - Flags: review?(mkmelin+mozilla) → review+

I notice the first click on the toggle arrow after you press forward, that doesn't do anything. Only from the second click the area toggles closed.

Found the problem with the double click to collapse.
The "toggle" action checks if the bucket was opened but unfocused. We do that to allow users to use the shortcut to focus on an open bucket and interact with the attachments via keyboard.
I updated the click method to always trigger the right show/hide action.

Attachment #9206223 - Attachment is obsolete: true
Attachment #9206430 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9206430 [details] [diff] [review]
1695644-attachments-forward.diff

Review of attachment 9206430 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thx! r=mkmelin
Attachment #9206430 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → 88 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/c07c005869b9
Expand attachment pane when forwarding a message with multiple attachments. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED

Comment on attachment 9206430 [details] [diff] [review]
1695644-attachments-forward.diff

[Triage Comment]
Prerequisite for bug 1695521 and bug 1695644 per aleca.

Attachment #9206430 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.