1695702 - Ensure AppMenu panel position relative to the anchor matches the specification

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

Spinning this out from bug 1694976.

amylee writes: "The position of the menu is too high and too far to the right of the screen (please reference spec for position)"

Comment 1

[Tyler Duzan]

From my PM review, I immediately noticed this behavior and it appears to be different between platforms (and maybe themes). On Windows 10 w/ Light Theme it appears correctly, but on OS X w/ Dark Theme I see this defect. The AppMenu should be right-aligned to the edge of the hamburger button and the top of the menu should start after the bottom of the hamburger button. Right now on macOS it's aligned to the right edge of the browser window and covers up the bottom 6th of the hamburger button. It stands out in a not great way, I'd like to see this fixed if we have time during polish before shipping.

-> priority:2a

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Thanks for looking at this, emalysz! Just a heads up that there are some CSS rules that make these panels behave differently on macOS than on Windows and Linux. Specifically here: https://searchfox.org/mozilla-central/rev/05cea55db68db7a3c8531cadaa169e46176e3983/toolkit/themes/osx/global/popup.css#34-42

Also, a number of CSS rules have been added to nudge panels back and forth a bit: https://searchfox.org/mozilla-central/rev/05cea55db68db7a3c8531cadaa169e46176e3983/browser/themes/shared/customizableui/panelUI.inc.css#208-263

And those might need adjusting with Proton enabled.

Comment 3

[Emma Malysz]

Attachment: Bug 1695702, correctly position appMenu and panels when proton enabled

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4147649fcf95
correctly position appMenu and panels when proton enabled r=mconley

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4147649fcf95