1695721 - Safe mode toggle inside of AppMenu does not get an updated string when in Safe Mode

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Similar to bug 1692083, we need to update the string on the "safe mode" toggle in the AppMenu help subview to show the string for exiting safe mode.

This was originally fixed in 86 in bug 1692083, but wasn't fixed for 87+ because this item had originally been removed from the Help menu.

However, the item was re-added in bug 1690858, and the bug re-presented itself.

We should effectively port the fix from 1692083 to Nightly, and uplift to Beta.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1695721 - Make sure Safe Mode AppMenu menu item string gets updated when in Safe Mode. r?emalysz!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00c09ce9f4c4
Make sure Safe Mode AppMenu menu item string gets updated when in Safe Mode. r=emalysz

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/00c09ce9f4c4

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9206135 [details]
Bug 1695721 - Make sure Safe Mode AppMenu menu item string gets updated when in Safe Mode. r?emalysz!

Beta/Release Uplift Approval Request

• User impact if declined: Users who enter Safe Mode will not see the correct label for the menuitem that exits Safe Mode for them.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is basically a re-do of the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=1692083, which landed in 86. It's small, self-contained and well understood.
• String changes made/needed: None.

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9206135 [details]
Bug 1695721 - Make sure Safe Mode AppMenu menu item string gets updated when in Safe Mode. r?emalysz!

approved for 87.0b6

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d9218014667c

Comment 8

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in Nightly 89, Beta 88 and Release version 87 using Windows 10 and Ubuntu 20. In Release the string is updated to "Restart with Add-ons Enabled" and for Beta and Nightly the string is "Turn Troubleshoot Mode Off".