1695747 - Remove sponsored top sites from address bar results

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Jim T]

Sponsored top sites should not appear by default in the address bar. Previously this work was done for an experiment but should not be included in the default experience.

• Remove Sponsored Top Sites from address bar
• Organic Top Sites Should show in address bar
• Sponsored Top Sites should remain on about:newtab

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1695747 - Remove sponsored top sites from address bar results. r=mikedeboer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73339fe01d1b
Remove sponsored top sites from address bar results. r=mikedeboer

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 73339fe01d1b (Bug 1695747) for causing bc failures in browser_urlbar_telemetry_sponsored_topsites.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/c3d29f1a05dc18950522c4f11e1f54479f0c73b6
Push with failures, failure log.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dc290926288
Remove sponsored top sites from address bar results. r=mikedeboer

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2dc290926288

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9206246 [details]
Bug 1695747 - Remove sponsored top sites from address bar results. r=mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: There was some confusion with sponsored sites in the address bar and users not understanding how to disable them. This is a high priority as per https://jira.mozilla.com/browse/FIDE-406
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: I'm talking to QA to figure this out
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch is quite simple
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9206246 [details]
Bug 1695747 - Remove sponsored top sites from address bar results. r=mikedeboer

approved for 87.0b6

Comment 8

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on Linux Mint 20, Windows 10 and Mac 10.14.6 using Firefox Nightly 88.0a1 2021-03-03. (aided by the browser.topsites.experiment.ebay-2020-1 pref. in order to get sponsored tiles)

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/091e61be463f

Comment 10

[Adrian Florinescu [:aflorinescu]]

Verified the fix on 87.0b6 2021-03-04, using:

Preconditions: (to enable sponsored topsites)

   user_pref("browser.search.region","US");
   user_pref("browser.topsites.experiment.ebay-2020-1", true);

Os coverage:

   Ubuntu 18.04
   Mac 10.14.6
   Windows 10

Aditionally, we also verified that getting frecency counts on the site will add the topsite in cause as addressbar topsite if the sponsored would get dissabled.

e.g.:

1. amazon.com -> sponsored
2. generate amazon.com brwosing history
3. Switch the sponsored topsites off.

AR/ER:

1. amzon.com as sponsored topsite not present in address bar.
2. ammazon.com as topsite present in address bar.