1695790 - Reduce motion of the new attachments notification based on the toolkit.cosmeticAnimations.enabled pref

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, enhancement)

Description

[Alessandro Castellani [:aleca]]

The new counter animation to highlight a successful attachment is nice, but it might be annoying and damaging for users that set the pref toolkit.cosmeticAnimations.enabled to false.

Comment 1

[Richard Marti (:Paenglab)]

I don't think we should use toolkit.cosmeticAnimations.enabled as this seems to be deprecated, see Bug 1640501 and his meta bug 1478597.

Better would be to use the media query for prefers-reduced-motion.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1695790-disable-new-attachment-animation.patch

Something like this?

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9206378 [details] [diff] [review]
1695790-disable-new-attachment-animation.patch

Review of attachment 9206378 [details] [diff] [review]:
-----------------------------------------------------------------

This is great, thanks for taking care of it.

::: mail/themes/shared/mail/messengercompose.css
@@ +264,5 @@
>    margin-inline-end: -29px;
>    opacity: 0;
>  }
>  
> +@media (prefers-reduced-motion: no-preference) {

Can we also add here this little snippet?
#attachmentToggle {
transition: transform 200ms ease;
}

A tiny animation for the rotating twisty, what do you think?

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1695790-disable-new-attachment-animation.patch

Added the #attachmentToggle animation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d2549cb67cb8
Don't show the add attachment animation when prefers-reduced-motion is set. r=aleca