Introduce about:third-party page
Categories
(Firefox :: Launcher Process, enhancement)
Tracking
()
People
(Reporter: toshi, Assigned: toshi)
References
(Blocks 1 open bug)
Details
Attachments
(10 files, 1 obsolete file)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
81.58 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Now that the new section "Third-Party Modules" in about:support (bug 1669036) has landed on the release version, let's start prototyping a new about:third-party page.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
This patch adds a blank page about:third-party along with a skeleton XPCOM
object AboutThirdParty which has a method to invoke a background task in C++.
Depends on D109302
Assignee | ||
Comment 3•4 years ago
|
||
This patch implements a frontend part of the about:third-party, showing
third-party module info based on the telemetry ping as we currently do in
the "Third-Party Modules" section in the about:support page (bug 1669036).
Depends on D109303
Assignee | ||
Comment 4•4 years ago
|
||
This patch adds a feature to mark each module in the about:third-party page
as a shell extension or an IME if it is so. To achieve this, when the page
is loaded, it starts a background task to collect registered shell extensions
from the registry and adds a tag next to a module's name.
Depends on D109304
Assignee | ||
Comment 5•4 years ago
|
||
This patch adds application info (Name and Publisher for now) in the
about:third-party page if a module is a part of an installed application,
which is registered in the registry and shown in Windows Control Panel.
To achieve this, we parse the registry to collect installed applications
in the background task.
Depends on D109305
Assignee | ||
Comment 6•4 years ago
|
||
This patch adds a new mochitest to verify the content on about:third-party.
As a third-party module to test, this patch adds a new DLL TestShellEx.dll
which works as an Icon Handler Shell Extension.
Depends on D109306
Assignee | ||
Comment 7•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 8•4 years ago
|
||
This patch is to show a warning icon for a module which caused crash
i.e. if CrashManager
has a record where the crashing address was within
the module's mapped region.
Assignee | ||
Comment 9•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 10•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 11•4 years ago
|
||
Comment 12•4 years ago
|
||
Comment 13•4 years ago
|
||
Backed out for causing failures at browser_all_files_referenced.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/f30905564afba06ec53064c9ef2ea8a63bb9bfe0
Failure log: https://treeherder.mozilla.org/logviewer?job_id=341019385&repo=autoland&lineNumber=2618
Comment 15•4 years ago
|
||
Comment 16•4 years ago
|
||
Backed out for causing build bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/f6190339babcefdded79a0b47ea4dd035d777e06
Failure log: https://treeherder.mozilla.org/logviewer?job_id=341036028&repo=autoland&lineNumber=36665
Assignee | ||
Comment 17•4 years ago
|
||
Hmm, somehow the icon file in the Part7 became empty.
Comment 18•4 years ago
|
||
Comment 19•4 years ago
|
||
Backed out 9 changesets (Bug 1695817) for causing bc failures in content/aboutThirdParty.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/c884d008db5c45825972f442c7a8010eafd339fc
Push with failures, failure log
Assignee | ||
Comment 20•4 years ago
|
||
It seems MOZ_CRASHREPORTER
is not defined in ASan build on autoland. Updated the Part8 patch.
Comment 21•4 years ago
|
||
Comment 22•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9d48d8ab9d65
https://hg.mozilla.org/mozilla-central/rev/1bc11fed0fa7
https://hg.mozilla.org/mozilla-central/rev/01e6b8919218
https://hg.mozilla.org/mozilla-central/rev/cef7309a8e3c
https://hg.mozilla.org/mozilla-central/rev/9494a0c6f129
https://hg.mozilla.org/mozilla-central/rev/2e4e5decb750
https://hg.mozilla.org/mozilla-central/rev/a6a7d4df5ca4
https://hg.mozilla.org/mozilla-central/rev/3214e7781afd
https://hg.mozilla.org/mozilla-central/rev/df2befd2754e
Comment 23•4 years ago
|
||
Is this worth calling out in firefox 90 release notes, or not quite yet? (If yes, see https://wiki.mozilla.org/Release_Management/Release_Notes#Nomination_in_Bugzilla)
Assignee | ||
Comment 24•4 years ago
|
||
(In reply to Julien Cristau [:jcristau] from comment #23)
Is this worth calling out in firefox 90 release notes, or not quite yet? (If yes, see https://wiki.mozilla.org/Release_Management/Release_Notes#Nomination_in_Bugzilla)
Thank you for the suggestion. Yes, we want to add a note about this!
Release Note Request (optional, but appreciated)
[Why is this notable]: We introduce a new page for Windows users to see the list of third-party modules injected into Firefox. If they know this feature, they may be able to triage compatibility issues by themselves.
[Affects Firefox for Android]: No
[Suggested wording]: Firefox for Windows now offers a new page about:third-party to help users identify compatibility issues caused by third-party applications.
[Links (documentation, blog post, etc)]: We're preparing a SUMO article to which we want to have a link, but it's not available yet.
Comment 25•4 years ago
|
||
Can you help me understand where these two strings are used? I've been staring at the code for a while, and can't tell
https://hg.mozilla.org/mozilla-central/rev/01e6b8919218#l4.16
+third-party-header-module-list = Module list
+third-party-header-loading-events = Loading events
In the last is unclear if loading is a verb or an adjective. I assume it's a verb, which makes it sound like the string is missing an ellipsis at the end.
Assignee | ||
Comment 26•4 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #25)
Can you help me understand where these two strings are used? I've been staring at the code for a while, and can't tell
https://hg.mozilla.org/mozilla-central/rev/01e6b8919218#l4.16+third-party-header-module-list = Module list +third-party-header-loading-events = Loading events
In the last is unclear if loading is a verb or an adjective. I assume it's a verb, which makes it sound like the string is missing an ellipsis at the end.
Oh, thank you for looking at the code. These are unused and I forgot to remove them. I'll file a bug.
Updated•4 years ago
|
Description
•