1669036 - Add a new section showing third-party modules info to the about:support page

Status: RESOLVED FIXED

(Firefox :: Launcher Process, enhancement)

Description

[Toshihito Kikuchi [:toshi]]

We plan to introduce a way to disclose third-party modules to the users (Bug 1669035). As the first step, we plan to add a new section to the about:support page, showing all information we have about third-party modules. It's mostly included in the third-party modules ping.

Comment 1

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part1: Add a new GTest suite UntrustedModulesFixture

This is a test-only change adding a new testsuite to test the infrastructure
of the third-party modules ping.

Comment 2

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part2: Introduce UntrustedModulesDataSerializer

This patch refactors the function design to convert UntrustedModulesData
to a JS object by introducing UntrustedModulesDataSerializer, with which
we can serialize multiple data objects into a single JS object
with more flexibility.

Depends on D93823

Comment 3

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part3: Add CombinedStacks::AddStacks to append CombinedStacks to CombinedStacks.

This patch adds a method to merge two CombinedStacks instances.

Depends on D93824

Comment 4

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part4: Make UntrustedModulesData copyable

This patch makes UntrustedModulesData copyable in order to keep its instances
in the browser process even after we invoke Telemetry.getUntrustedModuleLoadEvents().

Depends on D93825

Comment 5

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part4: Introduce UntrustedModulesBackupData

This patch introduces a new strcuture UntrustedModulesBackupData, which is
designed to hold multiple UntrustedModulesData instances as a hash table whose
key is a pair of PID and ProcessType.

With this structure, when Telemetry.getUntrustedModuleLoadEvents() is invoked,
an instance of UntrustedModulesData is transferred from each process to the
main process as usual, and then we not only convert it to a JS object to present
to the method's caller, but also copy an instance of UntrustedModulesData
into the UntrustedModulesBackupData so that we can retrieve it later.

Depends on D93826

Comment 6

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part5: Add the process type to the key of a per-proc object of the third-party module ping

Depends on D93827

Comment 7

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part6: Introduce options for Telemetry.getUntrustedModuleLoadEvents() to control data

The method Telemetry.getUntrustedModuleLoadEvents() used to move data, meaning
once it was called, the returned data was removed from the application so that
the same data will never be returned again.

This patch introduces two options INCLUDE_OLD_LOADEVENTS and KEEP_LOADEVENTS_NEW
to pass to the method, each of them is explained by the comment if nsITelemetry.idl.
Internally UntrustedModulesBackupService holds two storages "Staging" and "Settled".
We use the "Staging" to keep new instances, and "Settled" to keep old instances.

Depends on D93828

Comment 8

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part7: Add INCLUDE_PRIVATE_FIELDS_IN_LOADEVENTS

This patch introduces a new flag INCLUDE_PRIVATE_FIELDS_IN_LOADEVENTS
to the Telemetry.getUntrustedModuleLoadEvents() to include a file
object instead of the string field resolvedDllName so that the JS
caller can have more flexibility.

Depends on D93829

Comment 9

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part8: Add EXCLUDE_STACKINFO_FROM_LOADEVENTS

This patch introduces a new flag EXCLUDE_STACKINFO_FROM_LOADEVENTS to
the Telemetry.getUntrustedModuleLoadEvents() to excude the "combinedStacks"
field. With this flag, we can merge an instance of UntrustedModulesData
into a JS object directly without involving UntrustedModulesBackupData.

Depends on D93830

Comment 10

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part10: Add a new section "Third-Party Modules" to about:support

The new section is displayed when the browser.enableAboutThirdParty pref is true.

Depends on D93831

Comment 11

[Toshihito Kikuchi [:toshi]]

Here's the latest try job: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1d6bae17d6b26a081faec349dc66b2cc0868af1

Comment 12

[Toshihito Kikuchi [:toshi]]

Attachment: design-consideration-01.png

Comment 13

[Toshihito Kikuchi [:toshi]]

Attachment: design-consideration-02.png

Cleaned up columns and added icons.

Comment 14

[Toshihito Kikuchi [:toshi]]

The latest try job: https://treeherder.mozilla.org/jobs?repo=try&revision=9da5b8fdab27cc0a904a51952c004e723b2c70dd

Comment 15

[Toshihito Kikuchi [:toshi]]

Attachment: design-consideration-03.png

Comment 16

[Toshihito Kikuchi [:toshi]]

The latest Try job: https://treeherder.mozilla.org/jobs?repo=try&revision=f16370b9b808409588c54d9c7876359d8197a0d1&selectedTaskRun=NX7rMoDXTW6WZZHt47zahg.0

Comment 17

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1669036 - Part9: Move some SVGs from browser to toolkit to use them from about:support. r=Gijs

This patch moves the following SVGs from browser to toolkit so that a subsequent
patch can load panel-icon-folder.svg and connection-mixed-active-loaded.svg from
toolkit. The other two SVGs are moved to minimize a change in CSS and JS.

• panel-icon-folder.svg
• panel-icon-magnifier.svg
• connection-mixed-active-loaded.svg
• connection-mixed-passive-loaded.svg

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e779792d865
Part1: Add a new GTest suite UntrustedModulesFixture r=aklotz

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d35204f6569
Part2: Introduce UntrustedModulesDataSerializer r=aklotz
https://hg.mozilla.org/integration/autoland/rev/cf29ad24eea5
Part3: Add CombinedStacks::AddStacks to append CombinedStacks to CombinedStacks. r=janerik
https://hg.mozilla.org/integration/autoland/rev/91549922741f
Part4: Introduce UntrustedModulesBackupData r=aklotz
https://hg.mozilla.org/integration/autoland/rev/a025cdac711c
Part5: Add the process type to the key of a per-proc object of the third-party module ping r=aklotz
https://hg.mozilla.org/integration/autoland/rev/cd782ea33949
Part6: Introduce options for Telemetry.getUntrustedModuleLoadEvents() to control data r=aklotz,janerik
https://hg.mozilla.org/integration/autoland/rev/2d3dd096f49f
Part7: Add INCLUDE_PRIVATE_FIELDS_IN_LOADEVENTS r=aklotz,janerik
https://hg.mozilla.org/integration/autoland/rev/ad3942a4c1f2
Part8: Add EXCLUDE_STACKINFO_FROM_LOADEVENTS r=aklotz,janerik
https://hg.mozilla.org/integration/autoland/rev/d5b6e9d6b7aa
Part9: Move some SVGs from browser to toolkit to use them from about:support.  r=dao
https://hg.mozilla.org/integration/autoland/rev/3d158bac444d
Part10: Add a new section "Third-Party Modules" to about:support r=fluent-reviewers,jaws,Gijs

Comment 20

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on TestCombinedStacks.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/2cb0feddb37391989752ac46fb880f4c576a27f7
Log link: https://treeherder.mozilla.org/logviewer?job_id=324187685&repo=autoland&lineNumber=91400

Comment 21

[Toshihito Kikuchi [:toshi]]

Hmm, this build error only happened on build-linux64-base-toolchains/debug. Updated the Part3 patch to fix it.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1c79db20cb3
Part1: Add a new GTest suite UntrustedModulesFixture r=aklotz
https://hg.mozilla.org/integration/autoland/rev/301794281a55
Part2: Introduce UntrustedModulesDataSerializer r=aklotz
https://hg.mozilla.org/integration/autoland/rev/1a8a04a7ae1f
Part3: Add CombinedStacks::AddStacks to append CombinedStacks to CombinedStacks. r=janerik
https://hg.mozilla.org/integration/autoland/rev/ace784f1e51b
Part4: Introduce UntrustedModulesBackupData r=aklotz
https://hg.mozilla.org/integration/autoland/rev/b56353063d54
Part5: Add the process type to the key of a per-proc object of the third-party module ping r=aklotz
https://hg.mozilla.org/integration/autoland/rev/5d5f43a4d5d0
Part6: Introduce options for Telemetry.getUntrustedModuleLoadEvents() to control data r=aklotz,janerik
https://hg.mozilla.org/integration/autoland/rev/5b4ce8205662
Part7: Add INCLUDE_PRIVATE_FIELDS_IN_LOADEVENTS r=aklotz,janerik
https://hg.mozilla.org/integration/autoland/rev/3dd198cecf8c
Part8: Add EXCLUDE_STACKINFO_FROM_LOADEVENTS r=aklotz,janerik
https://hg.mozilla.org/integration/autoland/rev/bb888d44201a
Part9: Move some SVGs from browser to toolkit to use them from about:support.  r=dao
https://hg.mozilla.org/integration/autoland/rev/d9f8cdf2877b
Part10: Add a new section "Third-Party Modules" to about:support r=fluent-reviewers,jaws,Gijs

Comment 23

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/d1c79db20cb3
https://hg.mozilla.org/mozilla-central/rev/301794281a55
https://hg.mozilla.org/mozilla-central/rev/1a8a04a7ae1f
https://hg.mozilla.org/mozilla-central/rev/ace784f1e51b
https://hg.mozilla.org/mozilla-central/rev/b56353063d54
https://hg.mozilla.org/mozilla-central/rev/5d5f43a4d5d0
https://hg.mozilla.org/mozilla-central/rev/5b4ce8205662
https://hg.mozilla.org/mozilla-central/rev/3dd198cecf8c
https://hg.mozilla.org/mozilla-central/rev/bb888d44201a
https://hg.mozilla.org/mozilla-central/rev/d9f8cdf2877b