1695822 - Scrolling popup window content opened by extensions seems to be broken on Linux

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: recording.webm

STR;

1. Make sure WebRender is enabled.
2. Install this addon, https://addons.mozilla.org/firefox/addon/popup/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search
3. Click the popup addon icon at the right edge of the browser toolbar
4. Choose "Open this tab as a popup"
5. Scroll the content in the popup

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I have totally no idea why bug 1689189 caused this.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1689189

Comment 3

[Julien Cristau [:jcristau]]

Does this only happen with software webrender or hardware as well?

Comment 4

[Hiroyuki Ikezoe (:hiro)]

yes, I can reproduce this both with software/hardware webrender on Linux.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Can you attach your about:support? I'm not able to reproduce with WR nor SW-WR, wondering if there is anything interesting in your config.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)

I have totally no idea why bug 1689189 caused this.

This changed who got SW-WR, and that's it, so I'm guessing you must have been using Basic and got put on SW-WR?

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: about:support

Comment 8

[Lee Salzman [:lsalzman]]

Did bug 1698067 have any effect here?

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Lee Salzman [:lsalzman] from comment #8)

Did bug 1698067 have any effect here?

Linux isn't getting SW-WR popups by default right now. Only Windows gets it for transparent windows. You can get it with gfx.webrender.software.unaccelerated-widget.force set to true but that isn't the case here from the about:support. I wasn't able to reproduce either way.

Comment 10

[Darkspirit]

Debian Testing, Gnome Xwayland
Still reproducible. It can be fixed by resizing the popup a bit and it doesn't occur afterwards anymore.

mozregression --launch 2021-09-13 --pref gfx.webrender.all:true -a https://addons.mozilla.org/firefox/addon/popup/
MOZ_X11_EGL=1 mozregression --launch 2021-09-13 --pref gfx.webrender.all:true -a https://addons.mozilla.org/firefox/addon/popup/
MOZ_ENABLE_WAYLAND=1 mozregression --launch 2021-09-13 --pref gfx.webrender.all:true -a https://addons.mozilla.org/firefox/addon/popup/

mozregression --good 2020-09-13 --bad 2021-09-13 --pref gfx.webrender.all:true -a https://addons.mozilla.org/firefox/addon/popup/

10:48.12 INFO: Last good revision: 20ba0abd37d1a4409099fa83f0cc6bf15cfbba92
10:48.12 INFO: First bad revision: 52a4a14e2d32071fe9b15cdfa7d6e400f0d913c5
10:48.12 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=20ba0abd37d1a4409099fa83f0cc6bf15cfbba92&tochange=52a4a14e2d32071fe9b15cdfa7d6e400f0d913c5

52a4a14e2d32071fe9b15cdfa7d6e400f0d913c5 Kartikaya Gupta — Bug 1667202 - Allow scroll metadata creation even for APZ-disabled scrollframes. r=botond

Basic was unaffected:
mozregression --repo autoland --launch 52a4a14e2d32071fe9b15cdfa7d6e400f0d913c5 --pref gfx.webrender.force-disabled:true -a https://addons.mozilla.org/firefox/addon/popup/

OpenGL was unaffected:
mozregression --repo autoland --launch 52a4a14e2d32071fe9b15cdfa7d6e400f0d913c5 --pref gfx.webrender.force-disabled:true layers.acceleration.force-enabled:true -a https://addons.mozilla.org/firefox/addon/popup/

Comment 11

[Botond Ballo [:botond]]

Thanks, I can reproduce the issue.

I'll do some initial investigation to narrow down where the problem lies.

Comment 12

[Botond Ballo [:botond]]

The popup is not using APZ.

WebRender + no APZ is not a well-supported configuration, and I don't think we want to put effort into supporting it, because Fission is going to require APZ anyways. Rather, we want to enable APZ in the popup.

I was under the impression we did that in bug 1493208, but the pref we flipped there only affects windows of type eWindowType_popup, and in this case, the window type is eWindowType_dialog.

I looked into why that is, and it seems to me that windows created by extensions using browser.windows.create({ type: "popup" }) (as this extension does) always end up as eWindowType_dialog? I base that on the following:

• The implementation of browser.windows.create() adds "dialog" to the window features list if type: "popup" was provided. It does not seem to add "popup" to the feature list anywhere.
• The window features are then translated into nsIWebBrowserChrome flags:
  • "popup" in the feature list causes CHROME_WINDOW_POPUP to be set
  • "dialog" in the feature list causes CHROME_OPENAS_DIALOG to be set
• Finally, the window type is set based on the chrome flags:
  • it's initialized to eWindowType_dialog if CHROME_OPENAS_DIALOG is set
  • it's changed to eWindowType_popup if CHROME_WINDOW_POPUP is set

That seems to be consistent with bug 1253128 comment 0 which states that type=popup in the browser.windows API should create a "dialog" type window.

(cc @kmag in case I'm overlooking something obvious here)

Based on this, my tentative plan is to enable APZ for windows of type eWindowType_dialog. To limit the scope of this change, I plan to do it only for dialogs with remote content, similar to our current treatment of eWindowType_popup (otherwise, presumably some browser-native dialogs may be affected which may not be desirable).

Comment 13

[Botond Ballo [:botond]]

Attachment: Bug 1695822 - Track mHasRemoteContent for windows created using nsAppShellService. r=hiro

Comment 14

[Botond Ballo [:botond]]

Attachment: Bug 1695822 - Enable APZ for windows of type eWindowType_dialog with remote content. r=hiro

Depends on D125776

Comment 15

[Darkspirit]

(In reply to Botond Ballo [:botond] from comment #12)

dialogs with remote content

There are two other WebRender popup bugs on Linux:

• bug 1719898 (caused by adding a HasRemoteContent() check)
• bug 1730822

Comment 16

[Botond Ballo [:botond]]

Hmm, with these patches, in a Try push I get toolkit/content/tests/chrome/test_popup_button.xhtml or toolkit/content/tests/chrome/test_popup_attribute.xhtml failing in M-1proc (with an OOM crash??) 3/10 times.

Treeherder suggests a known intermittent, bug 1609074, which has been duped over to bug 1607713, but without my patch the failure rate is 0/10.

Not quite sure what to make of that.

Comment 17

[Botond Ballo [:botond]]

(In reply to Darkspirit from comment #15)

There are two other WebRender popup bugs on Linux:

• bug 1719898 (caused by adding a HasRemoteContent() check)
• bug 1730822

I had a look, these ones look unrelated to APZ, but rather issues on the graphics side.

Comment 18

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #16)

Hmm, with these patches, in a Try push I get toolkit/content/tests/chrome/test_popup_button.xhtml or toolkit/content/tests/chrome/test_popup_attribute.xhtml failing in M-1proc (with an OOM crash??) 3/10 times.

Treeherder suggests a known intermittent, bug 1609074, which has been duped over to bug 1607713, but without my patch the failure rate is 0/10.

Not quite sure what to make of that.

After some additional retriggers, I did get the same failure even without my patch, so I guess the failure is unrelated to this change.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6bb1a5933b4
Track mHasRemoteContent for windows created using nsAppShellService. r=hiro
https://hg.mozilla.org/integration/autoland/rev/fb938cb58404
Enable APZ for windows of type eWindowType_dialog with remote content. r=hiro

Comment 20

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d6bb1a5933b4
https://hg.mozilla.org/mozilla-central/rev/fb938cb58404

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:botond, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 22

[Darkspirit]

Verified fixed. Thanks!
mozregression --launch 2021-09-19 --pref gfx.webrender.all:true -a https://addons.mozilla.org/firefox/addon/popup/

Comment 23

[Botond Ballo [:botond]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #21)

The patch landed in nightly and beta is affected.
:botond, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

Given that this has been broken for a while, and the change is in an area of code that's hard to test, I'd prefer to err on the side of letting this change ride the trains.