1719898 - EGL/X11: Main menu and toolbar panels don't show up if gfx.webrender.unaccelerated-widget.force=true

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Darkspirit]

Gnome Xwayland, Debian Testing, Intel

This bug does not seem to occur with MOZ_ENABLE_WAYLAND=1 or GLX.

MOZ_X11_EGL=1 mozregression --good 2021-05-01 --bad 2021-07-08 --pref gfx.webrender.all:true gfx.webrender.unaccelerated-widget.force:true -a about:config -a about:support

6:30.68 INFO: Last good revision: 3210b5354d3ee3ba3d3ff98e8e791409909d9db7
6:30.68 INFO: First bad revision: 5cf00c95d81b2eb4b28a1f7b6b0db7b01fba254a
6:30.68 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3210b5354d3ee3ba3d3ff98e8e791409909d9db7&tochange=5cf00c95d81b2eb4b28a1f7b6b0db7b01fba254a

5cf00c95d81b2eb4b28a1f7b6b0db7b01fba254a sotaro — Bug 1710855 - Do not allow acceleration to popup without remote content r=stransky

This commit fixed/circumvented bug 1572501 by enforcing software webrender in any case.

Comment 1

[Robert Mader [:rmader]]

Attachment: Bug 1719898 - Ignore WidgetTypeSupportsAcceleration() if webrender.unaccelerated-widget.force is enabled, r=#gfx-reviewers,aosmond,jrmuizel

Right now whenever WidgetTypeSupportsAcceleration() returns false
and webrender.unaccelerated-widget.force is enabled, things will
simply fail and the widget will just not get rendered (only since
Basic layers got removed?).

Thus ignore WidgetTypeSupportsAcceleration() in this case, that's
what the option is for.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/189fb42a52ba
Ignore WidgetTypeSupportsAcceleration() if webrender.unaccelerated-widget.force is enabled, r=aosmond,gfx-reviewers

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/189fb42a52ba

Comment 4

[Darkspirit]

https://hg.mozilla.org/integration/autoland/shortlog/189fb42a52ba
last bad: mozregression --repo autoland --launch 9065e6be26ac940213bb3b984cc38471e11aa247 --pref gfx.webrender.all:true gfx.x11-egl.force-enabled:true gfx.webrender.unaccelerated-widget.force:true
first good: mozregression --repo autoland --launch 189fb42a52bae7b2b534137ef2eb448313c35ca4 --pref gfx.webrender.all:true gfx.x11-egl.force-enabled:true gfx.webrender.unaccelerated-widget.force:true