1695937 - Add intl::NumberFormat and use it to format numbers in Fluent

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P1)

Description

[Dan Minor [:dminor]]

This will add an initial NumberFormat implementation to intl/components that has sufficient functionality to support formatting Fluent numbers, and switch Fluent over to using it.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1695937 - Add intl::NumberFormat to components; r=zbraniecki!

This adds an initial version of NumberFormat that is suitable for use by
Fluent.

The options formatting code is taken from SpiderMonkey and modified to use the
standard c++ library rather than SpiderMonkey specific code. The code
generated MeasureUnitGenerated.h is duplicated here temporarily. Once we can
move SpiderMonkey to using this code, we can update the code generation to
avoid this duplication.

Some simple gtests have been written to make development easier. Full test
coverage is not a goal here, as this code will eventually be covered by running
test262 in SpiderMonkey.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1695937 - Switch FluentBundle to use intl::NumberFormat; r=zbraniecki!

Depends on D107223

Comment 3

[Dan Minor [:dminor]]

Anba, I think this is ready for you to have another look if you have some time. Thank you!

Comment 4

[Dan Minor [:dminor]]

I'm going to land this with the current reviews. There's follow on work in Bug 1701695, so there will be another chance to have a look at this code.

Comment 5

[Dan Minor [:dminor]]

A mach try auto run here: https://treeherder.mozilla.org/jobs?repo=try&revision=e8106ff6ab7f13ee169e11a362e69d01b69d43fd and a full job for Linux, just in case: https://treeherder.mozilla.org/jobs?repo=try&revision=4457294b5d9a5578198774e6c2029646fc05f1df. The failures all look like known intermittents.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/232a570d6739
Add intl::NumberFormat to components; r=zbraniecki,tcampbell,jandem
https://hg.mozilla.org/integration/autoland/rev/d17059c999a6
Switch FluentBundle to use intl::NumberFormat; r=zbraniecki,hsivonen,jfkthame

Comment 7

[Atila Butkovits]

Backed out for causing bustages on FluentBundle.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/87b4dfca8a62db71a72a17778ebc8bca2861c512

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=OUahwr-QRG-aMCnKHu_eUQ.0&revision=d17059c999a6f275259f566770f9b37b27d5d2ec&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2Cbb

Failure log: https://treeherder.mozilla.org/logviewer?job_id=335782134&repo=autoland&lineNumber=15878

Comment 8

[Dan Minor [:dminor]]

https://treeherder.mozilla.org/jobs?repo=try&revision=a985ccab05d022801efe5e537acbf6bbadc031ba

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d2fed16373f
Add intl::NumberFormat to components; r=zbraniecki,tcampbell,jandem
https://hg.mozilla.org/integration/autoland/rev/a895e219ce93
Switch FluentBundle to use intl::NumberFormat; r=zbraniecki,hsivonen,jfkthame

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9d2fed16373f
https://hg.mozilla.org/mozilla-central/rev/a895e219ce93