1696034 - VIDEO_ENCRYPTED_PLAY_TIME_MS telemetry probe is not being recorded

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

It looks like bug 1685399 accidentally removed this while moving code around. We should restore the probe as it's a useful checksum on other probes.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1685399

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1696034 - Restore code to record VIDEO_ENCRYPTED_PLAY_TIME_MS probe. r?alwu

This code didn't make it across when we reworked how we record our playback
probes. However, it's a useful checksum to compare against our Widevine
playtime + as a general data point. This patch restores the code to record the
probe.

Comment 3

[Tim Spurway [:tspurway]]

bryce did you want to get this in by 88?

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I think it's going to miss that boat at this stage. I'd like to get a test for it, and doing so is non-trivial as we do not have prior art and since I have a few other pots on the boil. So I think this will have to slip for now.

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1696034 - Add a browser test to verify EME related playtime telemetry is gathered. r?alwu

This changeset adds a test to verify that playtime telemetry related to EME is
gathered after playing an encrypted file. It does so by checking that the
VIDEO_ENCRYPTED_PLAY_TIME_MS and VIDEO_CLEARKEY_PLAY_TIME_MS are the same as the
VIDEO_PLAY_TIME_MS after playing an encrypted file (this may not always happen
in the wild, but should hold for test).

To support this test I've added a new eme helper file eme_standalone.js this
is an EME helper with no extra dependencies. This allows it to be used in normal
mochitests and browser mochitests, rather than just one or the other. It is also
not coupled with the media mochitests (and manifest.js) unlike our existing
EME helpers, so should be more portable.

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1696034 - Expand EME telemetry test to cover cases involving unecnrypted media. r?alwu

Expands the EME telemetry test to cover two additional cases.

1. The EME media is loaded but before playback the src is switched to unecrypted
   media. In this case, we don't expect encrypted playtime to be recorded, but
   we will still collect clearkey playtime as the element still has clearkey
   media keys attached.
2. Same as the above, but where the media keys are also cleared. In this case we
   do not expect either encrypted or clearkey time to be recorded.

Depends on D110446

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11ce9b421549
Add a browser test to verify EME related playtime telemetry is gathered. r=alwu
https://hg.mozilla.org/integration/autoland/rev/5f6bfe095712
Expand EME telemetry test to cover cases involving unecnrypted media. r=alwu
https://hg.mozilla.org/integration/autoland/rev/3c6dd9208e43
Restore code to record VIDEO_ENCRYPTED_PLAY_TIME_MS probe. r=alwu

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/11ce9b421549
https://hg.mozilla.org/mozilla-central/rev/5f6bfe095712
https://hg.mozilla.org/mozilla-central/rev/3c6dd9208e43