Closed Bug 1696045 Opened 3 years ago Closed 3 years ago

Add AVIF telemetry for unimplemented features and performance

Categories

(Core :: Graphics: ImageLib, task, P2)

task

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox92 --- fixed
firefox93 --- fixed

People

(Reporter: jbauman, Assigned: jbauman)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

To provide better insight on usage and prioritization of additional feature work for AVIF generally, it's valuable to generate telemetry which can indicate when attempts are made to use features that haven't yet been implemented. Additionally tracking parsing and decoding time would be valuable. In some cases, this requires a bit of extra work to detect that a file attempts to make use of an unimplemented feature and communicate that back to the code where we can record telemetry

Summary: Add AVIF telemetry for unimplemented features → Add AVIF telemetry for unimplemented features and performance

Additionally, AVIF should have a version of the probes like Telemetry::IMAGE_DECODE_SPEED_{GIF,JPEG,PNG,WEBP}

Moving to no longer block 1682995 since we'd like to enable AVIF by default for 92 and this can be added as an early uplift

Blocks: AVIF
No longer blocks: avif-default
Depends on: 1726410
Depends on: 1726830

Thanks for the review!

Flags: needinfo?(tlong)
Attachment #9237591 - Flags: data-review?(tlong)
Attachment #9237561 - Attachment description: WIP: Bug 1696045 - Add AVIF telemetry for unimplemented features and performance. → Bug 1696045 - Add AVIF telemetry for unimplemented features and performance. r=aosmond

Comment on attachment 9237591 [details]
data_review-bug-1696045.md

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through Histograms.json, metrics.yaml, and the Probe Dictionary.

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the standard telemetry preference

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Chun-Min Chang and Jon Bauman will be responsible for the permanent collection of this data.

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical data

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

Flags: needinfo?(tlong)
Attachment #9237591 - Flags: data-review?(tlong) → data-review+

Backed out for causing gtest failures in image/decoders/nsAVIFDecoder

Backout link: https://hg.mozilla.org/integration/autoland/rev/41efb45c6ea53038f8092f54a03b2da0414f7500

Push with failures

Failure log

Flags: needinfo?(jbauman)

🤦

I ran these tests in try, but I thought Hit MOZ_CRASH(Initial entry store size is too large) at /builds/worker/checkouts/gecko/xpcom/ds/PLDHashTable.cpp:174 from bug 1714500 was the issue and missed my failure further down.

The problem is straightforward, and I should have a fix very shortly.

Flags: needinfo?(jbauman)
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Comment on attachment 9237561 [details]
Bug 1696045 - Add AVIF telemetry for unimplemented features and performance. r=aosmond

Beta/Release Uplift Approval Request

  • User impact if declined: Less insight into AVIF in the field per our plan from bug 1443863 comment 80
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1726410, Bug 1726830
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No new user-facing features, only telemetry + minimal plumbing changes
  • String changes made/needed:
Attachment #9237561 - Flags: approval-mozilla-beta?

Comment on attachment 9237561 [details]
Bug 1696045 - Add AVIF telemetry for unimplemented features and performance. r=aosmond

Approved for 92.0rc1.

Attachment #9237561 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Regressions: 1728315
You need to log in before you can comment on or make changes to this bug.