1696058 - Normandy should not attempt to unenroll expired preference experiments who's filters don't match

Status: VERIFIED FIXED

(Firefox :: Normandy Client, defect, P1)

Description

[Michael Cooper [:mythmon]]

If Normandy client has a preference experiment that has already unenrolled, and receives the recipe for that experiment again, it will re-evaluate the filters. If the filters don't match, it will try to unenroll the client from the experiment, which fails because the client is already unenrolled. This is producing a lot of bad telemetry (see bug 1693402)

Comment 1

[Michael Cooper [:mythmon]]

Attachment: Bug 1696058 - Normandy should not attempt to unenroll experiments that have already been unenrolled. r=Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e278d44bfac
Normandy should not attempt to unenroll experiments that have already been unenrolled. r=Gijs

Comment 3

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (bug 1693581, bug 1689502, bug 1696058) for causing bc failures in browser_Troubleshoot.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/1869ce68e5daed9f9802be0764f0eee5b850202d
Push with failures, failure log,

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9311e0f6380
Normandy should not attempt to unenroll experiments that have already been unenrolled. r=Gijs

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c9311e0f6380

Comment 6

[Michael Cooper [:mythmon]]

Clients with this patch have stopped sending unenrollFailed reason=already-unenrolled events.

https://sql.telemetry.mozilla.org/queries/78565/source