1696132 - Form Autofill dropdown for saved addresses is barely visible on Ubuntu 20.04

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Catalin Sasca, Desktop QA [:csasca]]

Attachment: barely visible dropdown

Affected versions

• Firefox 87.0b5
• Firefox 88.0a1

Affected platforms

• Ubuntu 20.04

Steps to reproduce

1. Launch Firefox
2. Have a saved address and access this test page
3. Click on a form to trigger the address autofill

Expected result

• The contents of the address autofill dropdown are visible

Actual result

• The contents of the address autofill dropdown are barely visible, so do hovering over them

Regression range

• I will see for a regression

Additional notes

• The issue can be seen in the attachment
• macOS and windows are not affected
• The same behavior is reproducible with all the default themes

Comment 1

[Catalin Sasca, Desktop QA [:csasca]]

Attachment: Clear Fields.png

Comment 2

[Giorgia Nichita, Release Desktop QA]

This does not seem to be a regression, I can reproduced the issue way back on 59.0a1 (2017-12-01).

Comment 3

[Tim Giles [:tgiles]]

I'm going to check and see if this is still valid since Proton has landed.

Comment 4

[Tim Giles [:tgiles]]

Not reproducible on Ubuntu 18.04 or 20.04 on Firefox 91.0.2. I'm guessing we can close this one out.

Comment 5

[Tim Giles [:tgiles]]

This is still reproducible under certain conditions, but I've personally have been unable to reproduce on my Ubuntu boxes. This may be fixed by Bug 1697092.

Comment 6

[Tim Giles [:tgiles]]

Given the "Light" and "Standard" system themes in Ubuntu 20.04, can't reproduce. However, using the "Dark" system, the "Form Autofill Options" footer text is very low contrast. The options from the popup in all three cases are visible though, unlike the screenshot in comment 1...not sure what bug fixed that particular issue though.

It looks like it's going to be pretty tricky to get the correct system colors for each OS as Windows' FieldText defaults to black while Ubuntu's switches from black to white depending if the system theme is light or dark. I haven't checked against Mac but I'm sure that will throw another wrench into all of this. I guess we're going to need to define some more variables for autocomplete-item-shared.css to use since we can't override xul selectors in the OS specific autocomplete-item.css.

Comment 7

[Tim Giles [:tgiles]]

Went with an alternative solution, using the prefers-color-scheme CSS media feature. Instead of trying to trying to get all the OS to line up perfectly, we will check if an Ubuntu Linux user is using a dark theme and then fix the form autofill footer's text color so that it is visible.

Comment 8

[Tim Giles [:tgiles]]

Attachment: Bug 1696132 - Fix visibility of 'Form Autofill Options' footer on all platforms. r=#desktop-theme-reviewers

Comment 9

[Tim Giles [:tgiles]]

Linking some screenshots (since I can't easily attach multiple screenshots, not worried about link rot in this case) that correspond to diff 2 (id 484420) of the patch, since we might need some UX guidance if these changes are a bit too much.

Imgur link to collection of screenshots. They seem to have moved their order for whatever reason, not sure how to fix that so I'll list them out so it's easier for side by side comparison

• Mac dark theme, Mac light theme
• Ubuntu dark theme, Ubuntu light theme
• Windows dark theme, Windows light theme. Note, the Windows screenshots look very similar

Comment 10

[Tim Giles [:tgiles]]

Hey Sam, can you give your opinion on the screenshots in Comment #9? There is definitely a visual change depending on the platform, but I don't know if this would require UX's signoff. Appreciate the help!

Comment 11

[Sam Foster [:sfoster] (he/him)]

I left comments in phabricator. I think we do need that distinction between the list item above and the footer below.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92aee7fde9a1
Fix visibility of 'Form Autofill Options' footer on all platforms. r=sfoster,desktop-theme-reviewers,harry,mstange

Comment 13

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures in browser_parsable_css

Backout link

Push with failures

Failure log

Comment 14

[Tim Giles [:tgiles]]

Trying to land again since I cleared up the test failures.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c59068542535
Fix visibility of 'Form Autofill Options' footer on all platforms. r=sfoster,desktop-theme-reviewers,harry,mstange

Comment 16

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/c59068542535

Comment 18

[Monica Chiorean]

I was able to reproduce the issue on Ubuntu20.4 (87.0b5) using Ubuntu system dark theme.
Verified as fixed using different themes on Win10/Ubuntu 20.4 (Beta 94.0b4 and Nightly 95.0a1).