1696145 - Consider supporting silent flag for web notifications

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[codrut.topliceanu]

Needed for https://github.com/mozilla-mobile/fenix/issues/18145

Details:

• While at the moment Chrome mobile supports the flag but it ignores it, on desktop, however, it seems to work properly. There are plans for Chrome to implement it on mobile as well. (https://bugs.chromium.org/p/chromium/issues/detail?id=1181685)

• Doc: https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/showNotification

• Test website : https://web-push-book.gauntface.com/demos/notification-examples/

Comment 1

[Emily Toop (:fluffyemily)]

This is currently on the way to being supported by Chrome, so Fenix would like this soon.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

FWIW We need to plumb the dom bits too, doesn't look like we support it there either: https://searchfox.org/mozilla-central/rev/368607c4cd5be547021945e4ae60e8eb4365b3c4/dom/webidl/Notification.webidl#64-73

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1696145 - Add Array::From(nsTArray)

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1696145 - Support Notification.silent and .vibrate on Android.

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

This is ready to land but since we're almost into Nightly 90 I'm gonna wait and land it after the version bump.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d302afe732f
Add Array::From(nsTArray) r=aklotz
https://hg.mozilla.org/integration/autoland/rev/2e18b65dd133
Support Notification.silent and .vibrate on Android. r=smaug,droeh,aklotz

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for causing build bustage on notifications.

backout: https://hg.mozilla.org/integration/autoland/rev/d751a3b722eeedbde1d6987b3438e8ca795b7522

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=2e18b65dd133cd699dca3c1760c36c0605da3e85&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=337176447&repo=autoland&lineNumber=33006

[task 2021-04-20T17:02:40.400Z] 17:02:40     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/widget/windows'
[task 2021-04-20T17:02:40.405Z] 17:02:40     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -Xclang -std=c++17 -m32 -FoToastNotification.obj -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DCOMPILER_MSVC -DMOZ_UNICODE -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/widget/windows -I/builds/worker/workspace/obj-build/widget/windows -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/checkouts/gecko/layout/forms -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/style -I/builds/worker/checkouts/gecko/layout/xul -I/builds/worker/checkouts/gecko/toolkit/xre -I/builds/worker/checkouts/gecko/widget -I/builds/worker/checkouts/gecko/widget/headless -I/builds/worker/checkouts/gecko/xpcom/base -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -FI /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -fcrash-diagnostics-dir=/builds/worker/artifacts -TP -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Werror -I/builds/worker/workspace/obj-build/dist/include/cairo -Xclang -fexperimental-new-pass-manager  -Xclang -MP -Xclang -dependency-file -Xclang .deps/ToastNotification.obj.pp -Xclang -MT -Xclang ToastNotification.obj   /builds/worker/checkouts/gecko/widget/windows/ToastNotification.cpp
[task 2021-04-20T17:02:40.405Z] 17:02:40     INFO -  /builds/worker/checkouts/gecko/widget/windows/ToastNotification.cpp(92,70): error: too few arguments to function call, expected 14, have 12
[task 2021-04-20T17:02:40.405Z] 17:02:40     INFO -                    aPrincipal, aInPrivateBrowsing, aRequireInteraction);
[task 2021-04-20T17:02:40.405Z] 17:02:40     INFO -                                                                       ^
[task 2021-04-20T17:02:40.405Z] 17:02:40     INFO -  /builds/worker/workspace/obj-build/dist/include/nsIAlertsService.h(100,36): note: 'Init' declared here
[task 2021-04-20T17:02:40.405Z] 17:02:40     INFO -    JS_HAZ_CAN_RUN_SCRIPT NS_IMETHOD Init(const nsAString& aName, const nsAString& aImageURL, const nsAString& aTitle, const nsAString& aText, bool aTextClickable, const nsAString& aCookie, const nsAString& aDir, const nsAString& aLang, const nsAString& aData, nsIPrincipal *aPrincipal, bool aInPrivateBrowsing, bool aRequireInteraction, bool aSilent, const nsTArray<uint32_t >& aVibrate) = 0;
[task 2021-04-20T17:02:40.407Z] 17:02:40     INFO -                                     ^
[task 2021-04-20T17:02:40.407Z] 17:02:40     INFO -  1 error generated.
[task 2021-04-20T17:02:40.407Z] 17:02:40    ERROR -  make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:676: ToastNotification.obj] Error 1
[task 2021-04-20T17:02:40.407Z] 17:02:40     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/widget/windows'
[task 2021-04-20T17:02:40.407Z] 17:02:40     INFO -  make[4]: *** Waiting for unfinished jobs....

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d2c300cc463
Add Array::From(nsTArray) r=aklotz
https://hg.mozilla.org/integration/autoland/rev/1d2b794c296b
Support Notification.silent and .vibrate on Android. r=smaug,droeh,aklotz

Comment 9

[[ex-Mozilla] Agi Sferro | :agi]

Thanks!

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0d2c300cc463
https://hg.mozilla.org/mozilla-central/rev/1d2b794c296b

Comment 11

[Florin Strugariu [:Bebe]]

The alert is from this bug or previous 3 who have errors with building the tests:
Bug 1689741 Bug 1701787 Bug 1696145

== Change summary for alert #29823 (as of Mon, 26 Apr 2021 09:56:14 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
6%	youtube	dcf	windows10-64-shippable-qr	warm webrender	882.97 -> 828.67
4%	youtube	loadtime	windows10-64-shippable-qr	warm webrender	1,329.94 -> 1,273.46
3%	youtube	loadtime	linux1804-64-shippable-qr	warm webrender	1,336.38 -> 1,300.46
3%	youtube	dcf	linux1804-64-shippable-qr	warm webrender	1,226.25 -> 1,193.46
2%	youtube	dcf	linux1804-64-shippable-qr	warm webrender	1,222.92 -> 1,195.12
2%	youtube	dcf	linux1804-64-shippable	warm	1,187.19 -> 1,160.38

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29823