Closed Bug 1713284 Opened 3 years ago Closed 3 years ago

Crash in [@ mozilla::dom::SanitizeVibratePattern]

Categories

(GeckoView :: General, defect, P1)

Unspecified
Android

Tracking

(firefox89 unaffected, firefox90 wontfix, firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox89 --- unaffected
firefox90 --- wontfix
firefox91 --- fixed

People

(Reporter: fluffyemily, Assigned: agi)

References

(Regression)

Details

(Keywords: crash, regression, Whiteboard: [geckoview:m91])

Crash Data

Attachments

(1 file)

Crash report: https://crash-stats.mozilla.org/report/index/a8f3f23c-6a52-4100-ab49-c19e30210527

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(IsAtomic<uint32_t>::value || NS_IsMainThread()) (Non-atomic static pref 'dom.vibrator.max_vibrate_list_len' being accessed on background thread by getter)

Top 10 frames of crashing thread:

0 libxul.so mozilla::dom::SanitizeVibratePattern dom/base/Navigator.cpp:765
1 libxul.so mozilla::dom::Notification::CreateInternal dom/notification/Notification.cpp:913
2 libxul.so mozilla::dom::Notification::CreateAndShow dom/notification/Notification.cpp:2227
3 libxul.so mozilla::dom::Notification::ShowPersistentNotification dom/notification/Notification.cpp:2211
4 libxul.so mozilla::dom::ServiceWorkerRegistration::ShowNotification dom/serviceworkers/ServiceWorkerRegistration.cpp:344
5 libxul.so mozilla::dom::ServiceWorkerRegistration_Binding::showNotification_promiseWrapper dom/bindings/ServiceWorkerRegistrationBinding.cpp:525
6 libxul.so bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ConvertExceptionsToPromises> dom/bindings/BindingUtils.cpp:3296
7 libxul.so js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:512
8 libxul.so Interpret js/src/vm/Interpreter.cpp:3227
9 libxul.so js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:544
Severity: -- → S2
Priority: -- → P1
Whiteboard: [geckoview:m91]
Rank: 1
Assignee: nobody → agi
Regressed by: 1696145
Has Regression Range: --- → yes
Keywords: regression

Since Bug 1696145, this pref is accessed on background threads (from a service
worker) so we need to mark this pref atomic.

Attachment #9225945 - Attachment description: Bug 1713284 - Make max_vibrate_list_len atomic. → Bug 1713284 - Make max_vibrate_{list_len,ms} atomic.
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32e524b075a1
Make max_vibrate_{list_len,ms} atomic. r=smaug
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: