1696153 - Perma toolkit/components/passwordmgr/test/mochitest/test_prompt.html | Checking title visibility - got true, expected false when Gecko 88 merges to Beta on 2021-03-22

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log
  [task 2021-03-03T12:05:16.267Z] 12:05:16 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_prompt.html | Checking expected message
  [task 2021-03-03T12:05:16.267Z] 12:05:16 INFO - Buffered messages finished
  [task 2021-03-03T12:05:16.268Z] 12:05:16 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_prompt.html | Checking title visibility - got true, expected false
  [task 2021-03-03T12:05:16.268Z] 12:05:16 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:500:14
  [task 2021-03-03T12:05:16.268Z] 12:05:16 INFO - checkPromptState@toolkit/components/prompts/test/prompt_common.js:220:7
  [task 2021-03-03T12:05:16.268Z] 12:05:16 INFO - handlePrompt@toolkit/components/prompts/test/prompt_common.js:196:19

Comment 1

[Micah [:mtigley] (she/her)]

It looks like the modals in toolkit/components/passwordmgr/test/mochitest/test_prompt.html are using the window prompt type: https://searchfox.org/mozilla-central/rev/f83c67b24fed1d677c5deafe7b31f5656c2656ec/toolkit/components/passwordmgr/test/mochitest/test_prompt.html#25-26. However, the window subdialog pref is only enabled in Nightly so that's why the patch in Bug 1694415 landed and is failing when staging a merge into Beta.

Some background:
In Bug 1694415, I made it so these tests assumed the titles are always shown for anything opened on the tab level. So this should actually handle anything that's opened on the tab-level (and don't need to modify the titleHidden value in the passwordmgr prompt tests).

Now to actually handle the failure here, we could add another check in checkPromptState where if the windowPromptSubdialog pref is enabled and the modal type is a window type, we also assert the title is shown.

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1696153 - Make checkPromptState check if the prompt was opened with SubDialog. r=Gijs!

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This patch causes macOS failures for late betas because prompts.windowPromptSubDialog is only true for nightly and early betas.

Failure logs:

mochitest-plain
TEST-UNEXPECTED-FAIL | toolkit/components/prompts/test/test_bug619644.html | Checking title always visible on OS X or when opened with common dialog
TEST-UNEXPECTED-FAIL | toolkit/components/prompts/test/test_bug620145.html | Checking title always visible on OS X or when opened with common dialog
TEST-UNEXPECTED-FAIL | toolkit/components/prompts/test/test_dom_prompts.html | Checking title always visible on OS X or when opened with common dialog
TEST-UNEXPECTED-FAIL | toolkit/components/prompts/test/test_dom_prompts.html | Checking title always visible on OS X or when opened with common dialog
TEST-UNEXPECTED-FAIL | toolkit/components/prompts/test/test_subresources_prompts.html | Checking title always visible on OS X or when opened with common dialog

mochitest-chrome
TEST-UNEXPECTED-FAIL | toolkit/components/prompts/test/test_modal_prompts.html | Checking title always visible on OS X or when opened with common dialog
TEST-UNEXPECTED-FAIL | toolkit/components/prompts/test/test_modal_prompts.html | Checking title always visible on OS X or when opened with common dialog

Comment 4

[Micah [:mtigley] (she/her)]

I believe I've fixed the failures when either prompts.windowPromptSubDialog or prompts.contentPromptSubDialog is false (versions beyond Nightly and early Betas).

Are you able to run the tests for Beta with the current patch?

Comment 5

[Cosmin Sabou [:CosminS]]

Patch holds in latest beta-sim with patch applied.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/324466f8b5d3
Make checkPromptState check if the prompt was opened with SubDialog. r=Gijs

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/324466f8b5d3

Comment 8

[Alexandru Michis [:malexandru]]

Verified fixed in today's central-as-early-beta simulation.