Closed Bug 1696378 Opened 4 years ago Closed 4 years ago

uneven border width for focused and unstyled <input type="text"> with non-native theme on Windows

Categories

(Core :: Layout: Form Controls, defect)

defect

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- verified

People

(Reporter: aryx, Assigned: emilio)

References

Details

Attachments

(2 files)

Windows 8.1, Firefox 88.0a1 20210303215027

  1. Go to https://hg.mozilla.org/integration/autoland
  2. Click into the search box at the top right.

Actual result: uneven border width and a focus ring; if the border is supposed to create a 3D effect, then I don't see it

Expected result: Likely either a focus ring or a change to the box's border, and no 3D effect

Is this with WebRender enabled or disabled? What is window.devicePixelRatio?

Flags: needinfo?(aryx.bugmail)

With WebRender enabled, DPI is 1.25

Flags: needinfo?(aryx.bugmail)

Dupe of bug 477157?

No, not really.

This isn't really an uneven border (because we snap border widths
correctly); this is the textfield border snapping differently than the
outline, actually, in a way such that the outline shows underneath. We
use negative offsets to try to cover the border but that breaks in this
case.

I thought of two ways to fix it, but this one looks slightly more
future-proof (and simpler), see the comment in ComputeBorderColor. Let
me know if you want me to go the other way (snapping offsets instead) or
both, actually.

The transparent border uncovered that the radius was slightly off, and
also that I forgot to snap the auto-style outline width properly, so I
fixed those drive-by too (without the first one stuff looks off
otherwise, at least, the second one I could move).

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42731d5daba6 Fix snapping issues with outlines. r=mstange
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7127e946a01 Fix snapping issues with outlines. r=mstange
Flags: needinfo?(emilio)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Flags: qe-verify+

Reproduced the issue with Firefox 88.0a1 (20210304215542) on Windows 10x64 and DPI set to 125%.
The issue is verified fixed with Firefox 88.0b9 (20210408190318) while having widget.non-native-theme.enabled:true. The outline is properly displayed and even.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: