1696378 - uneven border width for focused and unstyled <input type="text"> with non-native theme on Windows

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Windows 8.1, Firefox 88.0a1 20210303215027

1. Go to https://hg.mozilla.org/integration/autoland
2. Click into the search box at the top right.

Actual result: uneven border width and a focus ring; if the border is supposed to create a 3D effect, then I don't see it

Expected result: Likely either a focus ring or a change to the box's border, and no 3D effect

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot input type text borders

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Is this with WebRender enabled or disabled? What is window.devicePixelRatio?

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

With WebRender enabled, DPI is 1.25

Comment 4

[Itiel]

Dupe of bug 477157?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

No, not really.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1696378 - Fix snapping issues with outlines. r=mstange

This isn't really an uneven border (because we snap border widths
correctly); this is the textfield border snapping differently than the
outline, actually, in a way such that the outline shows underneath. We
use negative offsets to try to cover the border but that breaks in this
case.

I thought of two ways to fix it, but this one looks slightly more
future-proof (and simpler), see the comment in ComputeBorderColor. Let
me know if you want me to go the other way (snapping offsets instead) or
both, actually.

The transparent border uncovered that the radius was slightly off, and
also that I forgot to snap the auto-style outline width properly, so I
fixed those drive-by too (without the first one stuff looks off
otherwise, at least, the second one I could move).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42731d5daba6
Fix snapping issues with outlines. r=mstange

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 42731d5daba6 (bug 1696378) for reftest failures in textarea-focus.html.
https://hg.mozilla.org/integration/autoland/rev/992d364ca303b751f20cd780c1d0b78bb8b37a34

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=42731d5daba63b8223bab83b772275ef03e44f6b&selectedTaskRun=Z6ypJKijQ_y8NE6tMO5zCA.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=332132702&repo=autoland&lineNumber=36474

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7127e946a01
Fix snapping issues with outlines. r=mstange

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fd39e6a5388
Fuzz other test annotation.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f7127e946a01
https://hg.mozilla.org/mozilla-central/rev/1fd39e6a5388

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

Reproduced the issue with Firefox 88.0a1 (20210304215542) on Windows 10x64 and DPI set to 125%.
The issue is verified fixed with Firefox 88.0b9 (20210408190318) while having widget.non-native-theme.enabled:true. The outline is properly displayed and even.