Right click contextmenu shows several unneeded separators at the top of the menu when opened with pocket disabled
Categories
(Firefox :: Menus, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox86 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | --- | verified |
People
(Reporter: mayankleoboy1, Assigned: Gijs)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [proton-context-menus])
Attachments
(4 files)
- Use my normal profile
- Type data:text/html, <html contenteditable> in the URLbar and press enter
- Right click in the text area
ER: normal right click menu
AR: right click menu has some rendering artifacts
2021-03-04T22:10:02.115000: DEBUG : Found commit message:
Bug 1691860, move code that hides separators in the content area context menu into a single place that just hides duplicates, r=Gijs,robwu
Differential Revision: https://phabricator.services.mozilla.com/D104615
2021-03-04T22:10:02.115000: DEBUG : Did not find a branch, checking all integration branches
2021-03-04T22:10:02.115000: INFO : The bisection is done.
2021-03-04T22:10:02.115000: INFO : Stopped
Reporter | ||
Comment 1•3 years ago
•
|
||
This doesnt happen on a fresh profile, so I dont know whats weird with my usual profile.
I tried disabling my addons, but could still repro this bug.
Reporter | ||
Comment 2•3 years ago
|
||
Reporter | ||
Comment 3•3 years ago
|
||
bug
Assignee | ||
Comment 4•3 years ago
|
||
are there errors in the browser console when this happens?
Assignee | ||
Updated•3 years ago
|
Reporter | ||
Comment 5•3 years ago
|
||
Not really sure: 2:37:58.305 debuggee 'resource://devtools/shared/base-loader.js:289' would run builtin-modules.js:196:11 22:37:58.495 debuggee 'resource://devtools/shared/base-loader.js:289' would run builtin-modules.js:196:11 22:38:06.741 [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 692" data: no] L10nRegistry.jsm:692:19 22:38:06.743 [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 692" data: no] L10nRegistry.jsm:692:19
Comment hidden (obsolete) |
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 7•3 years ago
•
|
||
Forgot to add that this is reproducible for me on any page.
- Go to google.com
- Right click on the page
ER: usual context menu
AR: menu with artifacts
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Comment 8•3 years ago
|
||
Does this reproduce for you in safe mode (with add-ons disabled) ?
Reporter | ||
Comment 9•3 years ago
|
||
(In reply to :Gijs (he/him) from comment #8)
Does this reproduce for you in safe mode (with add-ons disabled) ?
Yes
I started nightly while pressing the shift key, whihc starts in safe mode. I also tried clearing the startup cache, but that didnt help.
Assignee | ||
Comment 10•3 years ago
|
||
What are the contents of the user.js
file in your profile?
Reporter | ||
Comment 11•3 years ago
|
||
I pick the user.js file from here : C:\Users\Mayank\AppData\Roaming\Mozilla\Firefox\Profiles\o6bybjr3.default
user_pref("browser.tabs.warnOnClose", true);
#MozRunner Prefs Start 1614875705.8497157 71432cbf-f436-4e1f-ae81-6c5027f8dbe6
user_pref("app.update.enabled", false);
user_pref("app.update.auto", false);
user_pref("app.update.autodownload", "disabled");
user_pref("browser.sessionstore.resume_from_crash", false);
user_pref("browser.shell.checkDefaultBrowser", false);
user_pref("browser.tabs.warnOnClose", false);
user_pref("browser.warnOnQuit", false);
user_pref("datareporting.healthreport.uploadEnabled", false);
user_pref("datareporting.healthreport.documentServerURI", "http://%(server)s/healthreport/");
user_pref("datareporting.policy.dataSubmissionPolicyBypassNotification", true);
user_pref("toolkit.telemetry.enabled", false);
user_pref("extensions.autoDisableScopes", 0);
user_pref("browser.startup.homepage_override.mstone", "ignore");
#MozRunner Prefs End 1614875705.8497157 71432cbf-f436-4e1f-ae81-6c5027f8dbe6
Caveat: I have no idea who/what has put these in my user.js
Assignee | ||
Comment 12•3 years ago
|
||
I'm out of ideas of what would be different between your main profile and a new mozregression profile, except maybe spellcheck? Does the problem go away if you enable/disable spellcheck using that item in the context menu? Do you have any modified preferences listed in about:config relating to spellcheck (just search for "spell") ?
Neil, do you have ideas here?
Reporter | ||
Comment 13•3 years ago
•
|
||
OK, found it.
Add this to your prefs.js file while nightly is closed:
user_pref("extensions.pocket.enabled", false);
Comment 14•3 years ago
|
||
Looks like there are some pocket-related menus that are hidden using different means:
https://searchfox.org/mozilla-central/source/browser/base/content/browser.css#889
Assignee | ||
Comment 15•3 years ago
|
||
(In reply to Neil Deakin from comment #14)
Looks like there are some pocket-related menus that are hidden using different means:
https://searchfox.org/mozilla-central/source/browser/base/content/browser.css#889
Indeed. I can fix this.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 16•3 years ago
|
||
Comment 17•3 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bfe855d4d7b9 fix pocket-disabling-induced issues with separators in the context menus, r=NeilDeakin
Updated•3 years ago
|
Comment 18•3 years ago
|
||
bugherder |
Comment 19•3 years ago
|
||
Reproduced this issue using an old Nightly 2021-03-04 on Windows 10, verified that this is fixed using Latest Nightly 88.0a1 across platforms (Windows 10, Ubuntu 18.04 and macOS 11.3).
Updated•3 years ago
|
Description
•