1696473 - Assertion failure: !mIsBeingDestroyed, at src/docshell/base/nsDocShell.cpp:3983

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Tyson Smith [:tsmith]]

I am unable to get a relable test case. A Pernosco session will be attached shortly.

Assertion failure: !mIsBeingDestroyed, at src/docshell/base/nsDocShell.cpp:3983

#0 0x7faaf988ee89 in nsDocShell::LoadErrorPage(nsIURI*, char16_t const*, char const*, char const*, char16_t const*, char const*, nsIChannel*) src/docshell/base/nsDocShell.cpp:3983:3
#1 0x7faaf988c6ff in nsDocShell::DisplayLoadError(nsresult, nsIURI*, char16_t const*, nsIChannel*, bool*) src/docshell/base/nsDocShell.cpp:3957:9
#2 0x7faaf9899705 in DisplayLoadError src/docshell/base/nsDocShell.h:739:5
#3 0x7faaf9899705 in nsDocShell::EndPageLoad(nsIWebProgress*, nsIChannel*, nsresult) src/docshell/base/nsDocShell.cpp:6586:7
#4 0x7faaf98988b2 in nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) src/docshell/base/nsDocShell.cpp:5868:7
#5 0x7faaf989983f in non-virtual thunk to nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) src/docshell/base/nsDocShell.cpp
#6 0x7faaf50f101c in nsDocLoader::DoFireOnStateChange(nsIWebProgress*, nsIRequest*, int&, nsresult) src/uriloader/base/nsDocLoader.cpp:1332:3
#7 0x7faaf50f05ca in nsDocLoader::doStopDocumentLoad(nsIRequest*, nsresult) src/uriloader/base/nsDocLoader.cpp:938:14
#8 0x7faaf50eeb07 in nsDocLoader::DocLoaderIsEmpty(bool, mozilla::Maybe<nsresult> const&) src/uriloader/base/nsDocLoader.cpp:757:9
#9 0x7faaf50f07cc in ChildDoneWithOnload /builds/worker/workspace/obj-build/dist/include/nsDocLoader.h:243:5
#10 0x7faaf50f07cc in nsDocLoader::NotifyDoneWithOnload(nsDocLoader*) src/uriloader/base/nsDocLoader.cpp:832:14
#11 0x7faaf50eeb12 in nsDocLoader::DocLoaderIsEmpty(bool, mozilla::Maybe<nsresult> const&) src/uriloader/base/nsDocLoader.cpp:759:9
#12 0x7faaf50efa4d in nsDocLoader::OnStopRequest(nsIRequest*, nsresult) src/uriloader/base/nsDocLoader.cpp:640:5
#13 0x7faaf50f01ec in non-virtual thunk to nsDocLoader::OnStopRequest(nsIRequest*, nsresult) src/uriloader/base/nsDocLoader.cpp
#14 0x7faaf402c5e6 in mozilla::net::nsLoadGroup::NotifyRemovalObservers(nsIRequest*, nsresult) src/netwerk/base/nsLoadGroup.cpp:616:22
#15 0x7faaf402bb90 in mozilla::net::nsLoadGroup::Cancel(nsresult) src/netwerk/base/nsLoadGroup.cpp:250:11
#16 0x7faaf50ee398 in nsDocLoader::Stop() src/uriloader/base/nsDocLoader.cpp:253:36
#17 0x7faaf50ee2d1 in nsDocLoader::Stop() src/uriloader/base/nsDocLoader.cpp:251:3
#18 0x7faaf9869112 in Stop src/docshell/base/nsDocShell.h:186:25
#19 0x7faaf9869112 in nsDocShell::Stop(unsigned int) src/docshell/base/nsDocShell.cpp:4327:5
#20 0x7faaf9877ba5 in nsDocShell::Destroy() src/docshell/base/nsDocShell.cpp:4573:3
#21 0x7faaf5c11f5a in nsFrameLoader::DestroyDocShell() src/dom/base/nsFrameLoader.cpp:2003:20
#22 0x7faaf5c11e6a in nsFrameLoaderDestroyRunnable::Run() src/dom/base/nsFrameLoader.cpp:1939:21
#23 0x7faaf5aaa384 in mozilla::dom::Document::MaybeInitializeFinalizeFrameLoaders() src/dom/base/Document.cpp:8803:22
#24 0x7faaf5b14d76 in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1148:12
#25 0x7faaf5b14d76 in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1154:12
#26 0x7faaf5b14d76 in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1201:13
#27 0x7faaf593ee59 in nsContentUtils::RemoveScriptBlocker() src/dom/base/nsContentUtils.cpp:5568:17
#28 0x7faaf5aa3362 in mozilla::dom::Document::EndUpdate() src/dom/base/Document.cpp:7367:3
#29 0x7faaf5c2810f in ~mozAutoDocUpdate src/dom/base/mozAutoDocUpdate.h:34:18
#30 0x7faaf5c2810f in nsINode::RemoveChildNode(nsIContent*, bool) src/dom/base/nsINode.cpp:2112:1
#31 0x7faaf5c22414 in nsINode::RemoveChild(nsINode&, mozilla::ErrorResult&) src/dom/base/nsINode.cpp:808:3
#32 0x7faaf60a7b35 in mozilla::dom::Node_Binding::removeChild(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/NodeBinding.cpp:1132:60
#33 0x7faaf6e5891a in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) src/dom/bindings/BindingUtils.cpp:3233:13
#34 0x7faaf9efa1a1 in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) src/js/src/vm/Interpreter.cpp:435:13
#35 0x7faaf9ef9910 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) src/js/src/vm/Interpreter.cpp:520:12
#36 0x7faaf9efb0f3 in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) src/js/src/vm/Interpreter.cpp:580:10
#37 0x7faaf9eefde3 in CallFromStack src/js/src/vm/Interpreter.cpp:584:10
#38 0x7faaf9eefde3 in Interpret(JSContext*, js::RunState&) src/js/src/vm/Interpreter.cpp:3243:16
#39 0x7faaf9ee73c8 in js::RunScript(JSContext*, js::RunState&) src/js/src/vm/Interpreter.cpp:405:13
#40 0x7faaf9ef9931 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) src/js/src/vm/Interpreter.cpp:552:13
#41 0x7faaf9efb0f3 in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) src/js/src/vm/Interpreter.cpp:580:10
#42 0x7faaf9efb32f in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) src/js/src/vm/Interpreter.cpp:597:8
#43 0x7faafa48296b in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) src/js/src/jsapi.cpp:2861:10
#44 0x7faaf6b7a86c in mozilla::dom::EventListener::HandleEvent(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/EventListenerBinding.cpp:58:8
#45 0x7faaf71fc4e6 in void mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>(mozilla::dom::EventTarget* const&, mozilla::dom::Event&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/EventListenerBinding.h:65:12
#46 0x7faaf71fc22e in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) src/dom/events/EventListenerManager.cpp:1101:43
#47 0x7faaf71fceb0 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) src/dom/events/EventListenerManager.cpp:1298:17
#48 0x7faaf71f21e5 in HandleEvent /builds/worker/workspace/obj-build/dist/include/mozilla/EventListenerManager.h:390:5
#49 0x7faaf71f21e5 in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) src/dom/events/EventDispatcher.cpp:353:17
#50 0x7faaf71f1793 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) src/dom/events/EventDispatcher.cpp:555:16
#51 0x7faaf71f4345 in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) src/dom/events/EventDispatcher.cpp:1098:11
#52 0x7faaf71f6e76 in mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsPresContext*, nsEventStatus*) src/dom/events/EventDispatcher.cpp
#53 0x7faaf5c24223 in nsINode::DispatchEvent(mozilla::dom::Event&, mozilla::dom::CallerType, mozilla::ErrorResult&) src/dom/base/nsINode.cpp:1331:17
#54 0x7faaf593755a in nsContentUtils::DispatchEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, mozilla::Trusted, bool*, mozilla::ChromeOnlyDispatch) src/dom/base/nsContentUtils.cpp:4195:28
#55 0x7faaf59373e6 in nsContentUtils::DispatchTrustedEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, bool*) src/dom/base/nsContentUtils.cpp:4165:10
#56 0x7faaf5aa38d3 in mozilla::dom::Document::DispatchContentLoadedEvents() src/dom/base/Document.cpp:7452:3
#57 0x7faaf5b14d76 in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1148:12
#58 0x7faaf5b14d76 in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1154:12
#59 0x7faaf5b14d76 in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1201:13
#60 0x7faaf3e82612 in mozilla::SchedulerGroup::Runnable::Run() src/xpcom/threads/SchedulerGroup.cpp:146:20
#61 0x7faaf3e88b8f in mozilla::RunnableTask::Run() src/xpcom/threads/TaskController.cpp:472:16
#62 0x7faaf3e87106 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) src/xpcom/threads/TaskController.cpp:753:26
#63 0x7faaf3e85f64 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) src/xpcom/threads/TaskController.cpp:611:15
#64 0x7faaf3e86117 in mozilla::TaskController::ProcessPendingMTTask(bool) src/xpcom/threads/TaskController.cpp:395:36
#65 0x7faaf3e8c9a6 in operator() src/xpcom/threads/TaskController.cpp:133:37
#66 0x7faaf3e8c9a6 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_3>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:534:5
#67 0x7faaf3e9de97 in nsThread::ProcessNextEvent(bool, bool*) src/xpcom/threads/nsThread.cpp:1158:16
#68 0x7faaf3ea42ea in NS_ProcessNextEvent(nsIThread*, bool) src/xpcom/threads/nsThreadUtils.cpp:548:10
#69 0x7faaf47ba796 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:87:21
#70 0x7faaf4725dd3 in MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:335:10
#71 0x7faaf4725ced in RunHandler src/ipc/chromium/src/base/message_loop.cc:328:3
#72 0x7faaf4725ced in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:310:3
#73 0x7faaf85801e8 in nsBaseAppShell::Run() src/widget/nsBaseAppShell.cpp:137:27
#74 0x7faaf9dbec63 in XRE_RunAppShell() src/toolkit/xre/nsEmbedFunctions.cpp:902:20
#75 0x7faaf47bb67c in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:237:9
#76 0x7faaf4725dd3 in MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:335:10
#77 0x7faaf4725ced in RunHandler src/ipc/chromium/src/base/message_loop.cc:328:3
#78 0x7faaf4725ced in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:310:3
#79 0x7faaf9dbe838 in XRE_InitChildProcess(int, char**, XREChildData const*) src/toolkit/xre/nsEmbedFunctions.cpp:733:34
#80 0x55b9886b0f86 in content_process_main src/browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
#81 0x55b9886b0f86 in main src/browser/app/nsBrowserApp.cpp:306:18
#82 0x7fab08f170b2 in __libc_start_main /build/glibc-ZN95T4/glibc-2.31/csu/../csu/libc-start.c:308:16
#83 0x55b98868ed2c in _start (/home/worker/builds/m-c-20210214094209-fuzzing-debug/firefox-bin+0x14d2c)

Comment 1

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/px5hH4dIMusSD5kNWnc_gA/index.html

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1696473: End subframe loads for initial about:blank document on request error. r=nika

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kmag, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b15696335bd
End subframe loads for initial about:blank document on request error. r=nika

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for xpcshell failures on test_subframe_stop_after_parent_error.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a0c5d4fd645252e9bdda7ec0d44188a58384d8df
Log link: https://treeherder.mozilla.org/logviewer?job_id=338732471&repo=autoland&lineNumber=3711

Please also check :

1. https://treeherder.mozilla.org/logviewer?job_id=338732695&repo=autoland&lineNumber=3254
2. https://treeherder.mozilla.org/logviewer?job_id=338733925&repo=autoland&lineNumber=2686

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a04508cbc61
End subframe loads for initial about:blank document on request error. r=nika

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4a04508cbc61

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 9

[Kris Maglione [:kmag]]

This won't be a problem in the real world.