1696499 - Use "Troubleshoot Mode" instead of "Restart with Add-ons Disabled"

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Richard Marti (:Paenglab)]

Like FX we can use Troubleshoot Mode instead of Restart with Add-ons Disabled. This mode does not only disable Add-ons and it makes more sense to rename it to what it is for.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1696499-troubleshoot-mode.patch

I reordered the Troubleshoot Mode and the More Troubleshooting Information to be more logical (FX is doing this too soon).

I renamed more entities from ...safe... to ...troubleshoot.. than needed to get rid of the safe word.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: dialog.png

Wayne, what do you think to this wording?

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9206993 [details] [diff] [review]
1696499-troubleshoot-mode.patch

Review of attachment 9206993 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/helpMenu.inc.xhtml
@@ +38,5 @@
>                      label="&helpFeedbackPage.label;"
>                      accesskey="&helpFeedbackPage.accesskey;"
>                      oncommand="openFormattedURL('app.feedback.baseURL');"/>
>            <menuseparator id="functionsSeparator"/>
> +          <menuitem id="helpSafeMode"

Maybe we should also change the ID to "helpTroubleshootMode" for consistency.

::: mail/base/content/mailCore.js
@@ +773,5 @@
>      "chrome://messenger/locale/messenger.properties"
>    );
> +  let promptTitle = bundle.GetStringFromName("troubleshootModeRestartPromptTitle");
> +  let promptMessage = bundle.GetStringFromName("troubleshootModeRestartPromptMessage");
> +  let restartText = bundle.GetStringFromName("troubleshootModeRestartButton");

I think this is a good occasion to transition those strings to fluent, so we can ease up the future migration.
Would you be able to do it?

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9206996 [details]
dialog.png

I not keen on including the word "reset", because it contradicts/conflicts with the word "temporary". If this is the wording Firefox uses then I'd not deviate from that. But if Firefox doesn't have this word then I would remove it

Otherwise, f+

Comment 5

[Richard Marti (:Paenglab)]

Wayne, would be Troubleshoot Mode will disable all add-ons and temporarily use some default preferences be better?

Comment 6

[Wayne Mery (:wsmwk)]

Perfect

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1696499-troubleshoot-mode.patch

And how about this?

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1696499-troubleshoot-mode.patch

Fixed a linting error.

Comment 9

[Alessandro Castellani [:aleca]]

Comment on attachment 9207186 [details] [diff] [review]
1696499-troubleshoot-mode.patch

Review of attachment 9207186 [details] [diff] [review]:
-----------------------------------------------------------------

Good stuff, thanks for taking care of this.

::: mail/locales/en-US/messenger/menubar.ftl
@@ +11,5 @@
> +## Help Menu
> +
> +menu-help-enter-troubleshoot-mode =
> +    .label = Troubleshoot Mode…
> +    .accesskey = r

I'd use the occasion to select some "better" access keys for this labels.
This one can be T, since it's the primary action.

@@ +15,5 @@
> +    .accesskey = r
> +
> +menu-help-exit-troubleshoot-mode =
> +    .label = Turn Troubleshoot Mode Off
> +    .accesskey = r

This can be O, since the primary context of this action is to turn it Off.

@@ +19,5 @@
> +    .accesskey = r
> +
> +menu-help-more-troubleshooting-info =
> +    .label = More Troubleshooting Information
> +    .accesskey = T

And this can be I, for Information.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1696499-troubleshoot-mode.patch

Updated the accesskeys as discussed on Matrix.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e5ee749125a2
Use "Troubleshoot Mode" instead of "Restart with Add-ons Disabled". r=aleca

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/044e682c713f
follow-up - Include missing .ftl file in addressbook.xhtml. rs=bustage-fix