1696560 - Flex item's min size doesn't transfer to the opposite axis though aspect-ratio

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: flex-aspect-ratio-min-size.html

Load the attached testcase.

Google Chrome has the flex item of size 100x100, where we have 0x100.

I suppose the flex item's min-height:100px should be transferred to the inline axis through aspect-ratio per https://drafts.csswg.org/css-sizing-4/#aspect-ratio-size-transfers

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1696560 - Part 1: Move ComputeTransferredMinMaxInlineSize into AspectRatio.

So we can reuse this function in the next patch.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1696560 - Part 2: Support transferred min/max sizes for flex items when the main axis is the inline axis.

nsIFrame::ComputeSize() skip this case for flex items if the main axis
is the inline axis. Basically, flex items ignore their min & max sizing
properties in nsIFrame::ComputeSize() and we apply them later in the
flex reflow algorithm. Therefore, we also have to apply the transferred
min/max sizes together with its min & max sizing properties.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1696560 - Apply transferred min & max sizes for flex base size if main is the inline axis.

Basically, the transferred min & max sizes shouldn't override the min &
max sizing properties, so applying it earilier than these properties
should be identical. This just makes the flex base size ane main size be
more correct at the beginning (and so other adjustments of min/max sizes
in flex algorithm should override the transferred min/max sizes).

Comment 4

[Boris Chiou [:boris]]

Based on https://github.com/w3c/csswg-drafts/issues/6071#issuecomment-801338121:

So after discussing with fantasai, the css-sizing-4 transferred min/max size text should not apply in flexbox/grid. Instead, only the sizing inside those specs should apply.

Chrome and Safari still apply the transferred min/max size, but looks like we may not have to do this based on the spec issue comment.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa9e91285699
Apply transferred min & max sizes for flex base size if main is the inline axis. r=dholbert

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33799 for changes under testing/web-platform/tests

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/aa9e91285699

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on Firefox 100.0(20220428192727) on Windows 10 64-bits. Verified as fixed on Firefox 101.0b8(20220517185920) and Nightly 102.0a1(20220518214245) on Windown 10 64-bits, macOS 11 and Ubuntu 20.04