1696642 - The "Done" button from the Save Bookmark doorhanger is "unopinionated"

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Screenshot of the issue

Affected Versions:
Nightly 88.0a1 (2021-03-05)

Tested on:
Windows 10
MacOS 10.15

Steps to reproduce:

1. Got to any site
2. Click on the bookmark star icon
3. Check the "Done" option in the bookmark save doorhanger

Expected Results:
The "Done" option should have blue background color.
Actual Results:
The "Done" button is "unopinionated".

Regression-Range:
Regression caused by Bug 1696286.
2021-03-05T15:00:05.939000: DEBUG : Found commit message:
Bug 1696286 - Make it possible for PopupNotifications to be visually unopinionated. r=Gijs

Being 'visually unopinionated' means not showing distinct styling for the main action.

Differential Revision: https://phabricator.services.mozilla.com/D107128

Note:
I don't have any proton prefs enabled, this happens on a new Nightly profile.

Comment 1

[Timea Cernea [:tbabos][inactive]]

Hey Mike, that implementation should've been for proton-specific updates? I don't believe it should affect the bookmarks doorhanger especially when there are no proton prefs turned on. Please take a look at this when you have the time.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Fixed by a backout of bug 1696286. I'm going to reland something with a little more precision.

Comment 3

[Marco Bonardo [:mak]]

Mike, can we close this bug now? I cannot reproduce it anymore and bug 1696286 relanded.

Comment 4

[Timea Cernea [:tbabos][inactive]]

My apologies, I forgot about this one. I can safely close this bug now as it is indeed fixed with the backout Mike mentioned. Thanks

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Concur.