1696286 - Make it possible for PopupNotification's to be considered "unopinionated"

Status: RESOLVED FIXED

(Firefox :: Messaging System, task)

Description

[Mike Conley (:mconley) (:⚙️)]

Our PopupNotifications are, by default, opinionated by visually highlighting the main action. For Proton, we're (at least visually) moving away from putting our thumb on the scale on which permission we consider the "primary", and we want them to look equivalent to the other buttons.

This is only the case for some types of PopupNotifications, so I'm going to add an optional argument opinionated: false to the structure that a PopupNotification can be constructed with. This property will default to true if it's not passed.

The CSS will then be modified to only highlight the main action for panels that are opinionated.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1696286 - Disable main action highlight in PermissionUI panels when Proton is enabled. r?Gijs

Being 'visually unopinionated' means not showing distinct styling for the main action.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f8b367e18e3
Make it possible for PopupNotifications to be visually unopinionated. r=Gijs

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6f8b367e18e3

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out as per mconley`s request.
Backout link: https://hg.mozilla.org/integration/autoland/rev/2b508e9258a3d2b05608e852aa2d177accb7f835

Comment 5

[Mike Conley (:mconley) (:⚙️)]

It turns out that there was already a way to do this built-in to PopupNotifications and popupnotification.js, and I just never noticed it - one can pass disableHighlight on the mainAction, or set buttonhighlight="false" on the popupnotification to disable the default action highlighting. This was originally added in bug 1377006.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/419bc25a9148
Disable main action highlight in PermissionUI panels when Proton is enabled. r=Gijs

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/419bc25a9148