1696692 - Improve Ctrl+A/Cmd+A pill selection code and behaviour

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, enhancement)

Description

[Thomas D. (:thomas8)]

Let's improve code and behaviour of Ctrl/Cmd+A to select pills in composition.

• We should use early return/break wherever possible, for clarity and less indent.
• We should not trigger pill selection for Control+A on MAC, because that's an OS shortcut for other stuff.
• We should not trigger pill selection for Ctrl+Alt+A on Windows/Linux (even though that custom OS-level shortcut for starting an app of your choice will override us).
• Ctrl/Cmd+A on an empty address row should helpfully select all pills of all other rows instead of doing nothing. Common scenario e.g. when you have auto-CC/BCC, start with empty To, but don't want the auto-CC this time. Having to focus CC first is needlessly clumsy with an extra step. There's no reason to press Ctrl/Cmd+A on an empty row unless you actually intend to select something, and the only thing around is those other pills.

Comment 1

[Thomas D. (:thomas8)]

Attachment: 1696692_pills-ctrl+a.diff

This implements the improvements listed in comment 0.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9207189 [details] [diff] [review]
1696692_pills-ctrl+a.diff

Review of attachment 9207189 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0870a62e5554
Improve Ctrl+A/Cmd+A pill selection code and behaviour. r=aleca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8154af68f1e1
followup - fix linting. rs=eslint DONTBUILD