1696752 - Allow to Add Web Engines from the urlbar contextual menu

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Marco Bonardo [:mak]]

Part of bug 1691474

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1696752 - Allow to Add Web Engines from the urlbar contextual menu. r=harry

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a8323260fa7
Allow to Add Web Engines from the urlbar contextual menu. r=harry,desktop-theme-reviewers

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for build bustages on page_action_menu_add_search_engine

backout: https://hg.mozilla.org/integration/autoland/rev/d24b05bbf8bc1f7ea1e588069b69c93d52d18a2b

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=0a8323260fa70d20a0b6f58a0f0ace0769c5d77e&selectedTaskRun=Pi7vQznzSreRJ0Ezbj15fg.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=332520238&repo=autoland&lineNumber=74562

[task 2021-03-09T12:07:11.103Z] 12:07:11 INFO - package-tests> make[2]: Entering directory '/builds/worker/workspace/obj-build'
[task 2021-03-09T12:07:11.104Z] 12:07:11 INFO - package-tests> /builds/worker/workspace/obj-build/_virtualenvs/init_py3/bin/python -m mozbuild.action.process_install_manifest --track install__test_files.track _tests _build_manifests/install/_test_files
[task 2021-03-09T12:07:11.104Z] 12:07:11 ERROR - package-tests> Error: Symlink target path does not exist: /builds/worker/checkouts/gecko/browser/base/content/test/pageActions/page_action_menu_add_search_engine_2.xml
[task 2021-03-09T12:07:11.104Z] 12:07:11 ERROR - package-tests> Error: Symlink target path does not exist: /builds/worker/checkouts/gecko/browser/base/content/test/pageActions/page_action_menu_add_search_engine_one.html
[task 2021-03-09T12:07:11.105Z] 12:07:11 INFO - package-tests> BUILDTASK {"argv": ["/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/process_install_manifest.py", "--track", "install__test_files.track", "_tests", "_build_manifests/install/_test_files"], "start": 1615291599.0232522, "end": 1615291631.0756838, "context": null}
[task 2021-03-09T12:07:11.105Z] 12:07:11 ERROR - package-tests> Traceback (most recent call last):
[task 2021-03-09T12:07:11.105Z] 12:07:11 INFO - package-tests> File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
[task 2021-03-09T12:07:11.105Z] 12:07:11 INFO - package-tests> "main", mod_spec)
[task 2021-03-09T12:07:11.105Z] 12:07:11 INFO - package-tests> File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
[task 2021-03-09T12:07:11.105Z] 12:07:11 INFO - package-tests> exec(code, run_globals)
[task 2021-03-09T12:07:11.106Z] 12:07:11 INFO - package-tests> File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/process_install_manifest.py", line 133, in <module>
[task 2021-03-09T12:07:11.106Z] 12:07:11 INFO - package-tests> log_build_task(main, sys.argv[1:])
[task 2021-03-09T12:07:11.106Z] 12:07:11 INFO - package-tests> File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/util.py", line 18, in log_build_task
[task 2021-03-09T12:07:11.106Z] 12:07:11 INFO - package-tests> return f(*args, **kwargs)
[task 2021-03-09T12:07:11.106Z] 12:07:11 INFO - package-tests> File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/process_install_manifest.py", line 115, in main
[task 2021-03-09T12:07:11.107Z] 12:07:11 INFO - package-tests> defines=args.defines,
[task 2021-03-09T12:07:11.107Z] 12:07:11 INFO - package-tests> File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/process_install_manifest.py", line 71, in process_manifest
[task 2021-03-09T12:07:11.107Z] 12:07:11 INFO - package-tests> remove_empty_directories=remove_empty_directories,
[task 2021-03-09T12:07:11.107Z] 12:07:11 INFO - package-tests> File "/usr/lib/python3.7/contextlib.py", line 119, in exit
[task 2021-03-09T12:07:11.107Z] 12:07:11 INFO - package-tests> next(self.gen)
[task 2021-03-09T12:07:11.107Z] 12:07:11 INFO - package-tests> File "/builds/worker/checkouts/gecko/python/mozbuild/mozpack/errors.py", line 132, in accumulate
[task 2021-03-09T12:07:11.108Z] 12:07:11 INFO - package-tests> raise AccumulatedErrors()
[task 2021-03-09T12:07:11.108Z] 12:07:11 INFO - package-tests> mozpack.errors.AccumulatedErrors

Comment 4

[Marco Bonardo [:mak]]

uh, what is in phabricator is not what I see in my local hg, it's removing files I didn't remove, moving files I didn't move.
Not sure what's up here but my local changeset is different...

Comment 5

[Marco Bonardo [:mak]]

I hit a potential bug in moz-phab https://bugzilla.mozilla.org/show_bug.cgi?id=1697160 now updating with a workaround.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f0f6477c734
Allow to Add Web Engines from the urlbar contextual menu. r=harry,desktop-theme-reviewers

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5f0f6477c734

Comment 8

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We verified this issue using Fx 88.0b5 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 LTS.