Open Bug 1697160 Opened 4 years ago Updated 1 month ago

moz-phab deleted a file in the patch it uploaded (incorrect move/copy detection?)

Categories

(Conduit :: moz-phab, defect, P2)

Tracking

(Not tracked)

People

(Reporter: mak, Unassigned)

References

Details

(Keywords: conduit-triaged)

+++ This bug was initially created as a clone of Bug #1627405 +++

I'm creating the bug as a clone because it's very very similar.

My push of https://phabricator.services.mozilla.com/D107370 failed on missing files, that sounded strange because my Try push was fine.
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=0a8323260fa70d20a0b6f58a0f0ace0769c5d77e&selectedTaskRun=Pi7vQznzSreRJ0Ezbj15fg.0

Looking at the pushed diff I noticed a few things were different, in my local export I had:
copy from browser/base/content/test/pageActions/page_action_menu_add_search_engine_2.xml
copy to browser/components/urlbar/tests/browser-proton/add_search_engine_2.xml

But in the remote diff it became:
rename from browser/base/content/test/pageActions/page_action_menu_add_search_engine_2.xml
rename to browser/components/urlbar/tests/browser-proton/add_search_engine_2.xml

The same for browser/base/content/test/pageActions/page_action_menu_add_search_engine_one.html

The diff is copying files around, and in particular these 2 files are the only ones copied multiple times.

Note: using moz-phab --arc as suggested by Kwan workarounded the problem

Blocks: remove-arc
Assignee: nobody → zeid
Keywords: conduit-triaged
Priority: -- → P2
Assignee: zeid → nobody
You need to log in before you can comment on or make changes to this bug.