1696790 - Fix Cmd+Shift+Enter with focus on address input for "Send later" on Mac, and related nits/cleanup

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

From my reading of the code (can't test Mac):

STR

1. compose to [e-mail]
2. with focus in To or any autocomplete address input, press Cmd+Shift+Enter

Actual result

• Afasics, this will trigger "Send now", because the special hack we have in place is not aware of event.shiftKey and will always do cmd_sendWithCheck (send now).

Expected result

• should trigger "Send later" (cmd_sendLater) and move draft to Local folders / Outbox.

Comment 1

[Thomas D. (:thomas8)]

Attachment: 1696790_fix-Cmd+Shift+Enter.diff

Bug 1696790 - Fix Cmd+Shift+Enter with focus on address input for "Send later" on Mac. r=aleca

• Ensure Cmd+[Shift]+Enter to do cmd_sendWithCheck / cmd_sendLater respectively.
• Prevent unrelated key combos with Shift or Alt from sending or moving focus.
• Remove some unnecessary Mac tweaks involving event.stopPropagation().[*]
• Rewrite with early returns.

*: Unless Mac has an inbuilt function to move focus on Cmd+[Shift]+Enter, which is unlikely, I don't see the need for event.stopPropagation(), because we won't get into focus-moving when metaKey is involved.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9207298 [details] [diff] [review]
1696790_fix-Cmd+Shift+Enter.diff

Review of attachment 9207298 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/968f1d82c629
Fix Cmd+Shift+Enter with focus on address input for "Send later" on Mac. r=aleca